Re: [Qemu-devel] [PATCH 09/19] cpu: add helper cpu_exists(), to check if CPU with specified id exists

2013-04-12 Thread Igor Mammedov
On Thu, 11 Apr 2013 16:06:58 -0300 Eduardo Habkost wrote: > On Thu, Apr 11, 2013 at 04:51:48PM +0200, Igor Mammedov wrote: > > ... it should be used only on slow path since it does recursive search > > on /machine QOM tree for objects of TYPE_CPU > > > > Signed-off-by: Igor Mammedov > > Rev

Re: [Qemu-devel] [PATCH 09/19] cpu: add helper cpu_exists(), to check if CPU with specified id exists

2013-04-11 Thread Eduardo Habkost
On Thu, Apr 11, 2013 at 04:51:48PM +0200, Igor Mammedov wrote: > ... it should be used only on slow path since it does recursive search > on /machine QOM tree for objects of TYPE_CPU > > Signed-off-by: Igor Mammedov > Reviewed-by: Paolo Bonzini Why not implement this only after patch 21/22,

[Qemu-devel] [PATCH 09/19] cpu: add helper cpu_exists(), to check if CPU with specified id exists

2013-04-11 Thread Igor Mammedov
... it should be used only on slow path since it does recursive search on /machine QOM tree for objects of TYPE_CPU Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini --- v2: * s/get_firmware_id()/get_arch_id()/ rebase fixup * remove check for get_arch_id being NULL, since it's alwa