Re: [Qemu-devel] [PATCH 09/23] console: displaystate init revamp

2013-03-21 Thread Gerd Hoffmann
Hi, > Shouldn't get_alloc_displaystate() be used here instead? Thought about it, doesn't save a single line of code though, so I skipped the extra indirection. cheers, Gerd

Re: [Qemu-devel] [PATCH 09/23] console: displaystate init revamp

2013-03-20 Thread Igor Mitsyanko
On 03/20/2013 01:43 PM, Gerd Hoffmann wrote: > >> We have only one DisplayState, so there is no need for the "next" >> linking, rip it. Also consolidate all displaystate initialization >> into init_displaystate(). This function is called by vl.c after >> creating the devices (and thus all QemuCon

[Qemu-devel] [PATCH 09/23] console: displaystate init revamp

2013-03-20 Thread Gerd Hoffmann
We have only one DisplayState, so there is no need for the "next" linking, rip it. Also consolidate all displaystate initialization into init_displaystate(). This function is called by vl.c after creating the devices (and thus all QemuConsoles) and before initializing DisplayChangeListensers (aka