Re: [Qemu-devel] [PATCH 09/26] ehci: Use uframe precision for interrupt threshold checking

2012-12-18 Thread Hans de Goede
Hi, On 12/18/2012 12:03 PM, Gerd Hoffmann wrote: Hi, Can qemu not handle an mmio range where writes are trapped, but reads are not? That would force the use of the shadow variable, but should otherwise provide a nice speedup. No. vmexit is needed anyway btw, but the round-trip to qemu us

Re: [Qemu-devel] [PATCH 09/26] ehci: Use uframe precision for interrupt threshold checking

2012-12-18 Thread Gerd Hoffmann
Hi, > Can qemu not handle an mmio range where writes are trapped, but reads are > not? That would force the use of the shadow variable, but should otherwise > provide a nice speedup. No. vmexit is needed anyway btw, but the round-trip to qemu userspace could be short-cutted in theory. It's no

Re: [Qemu-devel] [PATCH 09/26] ehci: Use uframe precision for interrupt threshold checking

2012-12-18 Thread Hans de Goede
Hi, On 12/17/2012 03:51 PM, Gerd Hoffmann wrote: On 12/17/12 15:47, Hans de Goede wrote: Hi, On 12/17/2012 03:39 PM, Gerd Hoffmann wrote: On 12/17/12 15:23, Hans de Goede wrote: Hi, On 12/17/2012 02:16 PM, Gerd Hoffmann wrote: On 12/14/12 14:35, Hans de Goede wrote: Note that a shadow var

Re: [Qemu-devel] [PATCH 09/26] ehci: Use uframe precision for interrupt threshold checking

2012-12-17 Thread Gerd Hoffmann
On 12/17/12 15:23, Hans de Goede wrote: > Hi, > > On 12/17/2012 02:16 PM, Gerd Hoffmann wrote: >> On 12/14/12 14:35, Hans de Goede wrote: >>> Note that a shadow variable is used instead of changing frindex to >>> uframe accuracy because we must send a frindex which is a multiple of 8 >>> during mi

Re: [Qemu-devel] [PATCH 09/26] ehci: Use uframe precision for interrupt threshold checking

2012-12-17 Thread Gerd Hoffmann
On 12/17/12 15:47, Hans de Goede wrote: > Hi, > > On 12/17/2012 03:39 PM, Gerd Hoffmann wrote: >> On 12/17/12 15:23, Hans de Goede wrote: >>> Hi, >>> >>> On 12/17/2012 02:16 PM, Gerd Hoffmann wrote: On 12/14/12 14:35, Hans de Goede wrote: > Note that a shadow variable is used instead of c

Re: [Qemu-devel] [PATCH 09/26] ehci: Use uframe precision for interrupt threshold checking

2012-12-17 Thread Hans de Goede
Hi, On 12/17/2012 03:39 PM, Gerd Hoffmann wrote: On 12/17/12 15:23, Hans de Goede wrote: Hi, On 12/17/2012 02:16 PM, Gerd Hoffmann wrote: On 12/14/12 14:35, Hans de Goede wrote: Note that a shadow variable is used instead of changing frindex to uframe accuracy because we must send a frindex

Re: [Qemu-devel] [PATCH 09/26] ehci: Use uframe precision for interrupt threshold checking

2012-12-17 Thread Hans de Goede
Hi, On 12/17/2012 02:16 PM, Gerd Hoffmann wrote: On 12/14/12 14:35, Hans de Goede wrote: Note that a shadow variable is used instead of changing frindex to uframe accuracy because we must send a frindex which is a multiple of 8 during migration for migration compatibility, and rounding it down

Re: [Qemu-devel] [PATCH 09/26] ehci: Use uframe precision for interrupt threshold checking

2012-12-17 Thread Gerd Hoffmann
On 12/14/12 14:35, Hans de Goede wrote: > Note that a shadow variable is used instead of changing frindex to > uframe accuracy because we must send a frindex which is a multiple of 8 > during migration for migration compatibility, and rounding it down to > a multiple of 8 pre-migration, can lead to

[Qemu-devel] [PATCH 09/26] ehci: Use uframe precision for interrupt threshold checking

2012-12-14 Thread Hans de Goede
Before this patch, the following could happen: 1) Transfer completes, raises interrupt 2) .5 ms later we check if the guest has queued up any new transfers 3) We find and execute a new transfer 4) .2 ms later the new transfer completes 5) We re-run our frame_timer to write back the completion, but