Re: [Qemu-devel] [PATCH 1/1] Allow machines to configure the QEMU_VERSION that's exposed via hardware

2012-04-06 Thread Peter Maydell
On 5 April 2012 15:26, Crístian Viana wrote: > diff --git a/vl.c b/vl.c > index ae91a8a..7fea263 100644 > --- a/vl.c > +++ b/vl.c > @@ -1561,7 +1561,8 @@ static void main_loop(void) > >  static void version(void) >  { > -    printf("QEMU emulator version " QEMU_VERSION QEMU_PKGVERSION ", > Copyri

Re: [Qemu-devel] [PATCH 1/1] Allow machines to configure the QEMU_VERSION that's exposed via hardware

2012-04-05 Thread Crístian Viana
On 05-04-2012 11:48, Peter Maydell wrote: > This kind of change is definitely wrong -- where we're reporting > the QEMU version to the *user* we definitely don't want to introduce > the possibility of lying about it. > > (This is distinct from reporting the QEMU version to the *guest* > via device

[Qemu-devel] [PATCH 1/1] Allow machines to configure the QEMU_VERSION that's exposed via hardware

2012-04-05 Thread Crístian Viana
Based on the following conversation: http://mid.gmane.org/4f69f05b.5010...@codemonkey.ws > Which reminds me - qemu sticks the release version in > guest visible places like CPU version. > This is wrong and causes windows guests to print messages > about driver updates when you switch. > We should