Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects

2010-12-10 Thread Markus Armbruster
Jes Sorensen writes: > On 11/22/10 16:20, Anthony Liguori wrote: >> On 11/22/2010 09:10 AM, Jes Sorensen wrote: >>> On 11/22/10 16:08, Anthony Liguori wrote: On 11/22/2010 08:58 AM, Jes Sorensen wrote: > Right, the right solution is probably to create a block driver list > ar

Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects

2010-11-22 Thread Jes Sorensen
On 11/22/10 16:20, Anthony Liguori wrote: > On 11/22/2010 09:10 AM, Jes Sorensen wrote: >> On 11/22/10 16:08, Anthony Liguori wrote: >>> On 11/22/2010 08:58 AM, Jes Sorensen wrote: Right, the right solution is probably to create a block driver list argument for configure, similar

Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects

2010-11-22 Thread Anthony Liguori
On 11/22/2010 09:10 AM, Jes Sorensen wrote: On 11/22/10 16:08, Anthony Liguori wrote: On 11/22/2010 08:58 AM, Jes Sorensen wrote: On 11/22/10 15:54, Anthony Liguori wrote: Using block format whitelisting should be enough to disable nbd. I don't see a need for an explicit --d

Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects

2010-11-22 Thread Jes Sorensen
On 11/22/10 16:08, Anthony Liguori wrote: > On 11/22/2010 08:58 AM, Jes Sorensen wrote: >> On 11/22/10 15:54, Anthony Liguori wrote: >>> Using block format whitelisting should be enough to disable nbd. I >>> don't see a need for an explicit --disable-nbd option. >>> >> Right, the right solut

Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects

2010-11-22 Thread Anthony Liguori
On 11/22/2010 08:58 AM, Jes Sorensen wrote: On 11/22/10 15:54, Anthony Liguori wrote: On 11/22/2010 08:38 AM, Kevin Wolf wrote: You're free to dislike NBD as much as you want. Just compiling it out unconditionally and calling it a cleanup is a bit too much. ;-) A configure option for

Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects

2010-11-22 Thread Jes Sorensen
On 11/22/10 15:54, Anthony Liguori wrote: > On 11/22/2010 08:38 AM, Kevin Wolf wrote: >> You're free to dislike NBD as much as you want. Just compiling it out >> unconditionally and calling it a cleanup is a bit too much. ;-) >> >> A configure option for disabling NBD sounds reasonable, though I'm

Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects

2010-11-22 Thread Anthony Liguori
On 11/22/2010 08:38 AM, Kevin Wolf wrote: You're free to dislike NBD as much as you want. Just compiling it out unconditionally and calling it a cleanup is a bit too much. ;-) A configure option for disabling NBD sounds reasonable, though I'm not sure what you're trying to achieve with it. It do

Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects

2010-11-22 Thread Jes Sorensen
On 11/22/10 15:38, Kevin Wolf wrote: > Am 22.11.2010 15:27, schrieb Jes Sorensen: >> On 11/22/10 15:15, Kevin Wolf wrote: >> Well ok, seems a really backwards way to try and shoot yourself in the >> foot, but ok, maybe I should redo the patch to simply allow compiling >> NBD out instead. > > You'r

Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects

2010-11-22 Thread Kevin Wolf
Am 22.11.2010 15:27, schrieb Jes Sorensen: > On 11/22/10 15:15, Kevin Wolf wrote: >> Am 22.11.2010 15:08, schrieb Jes Sorensen: >>> I am aware of that, but what on earth is qemu-img doing with NBD in the >>> first place? Doesn't make much sense to me. >> >> The same as it's doing with file, host_de

Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects

2010-11-22 Thread Jes Sorensen
On 11/22/10 15:15, Kevin Wolf wrote: > Am 22.11.2010 15:08, schrieb Jes Sorensen: >> I am aware of that, but what on earth is qemu-img doing with NBD in the >> first place? Doesn't make much sense to me. > > The same as it's doing with file, host_device or http: Accessing images. > Start an NBD se

Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects

2010-11-22 Thread Kevin Wolf
Am 22.11.2010 15:08, schrieb Jes Sorensen: > On 11/22/10 13:24, Kevin Wolf wrote: >> Am 19.11.2010 17:30, schrieb jes.soren...@redhat.com: >>> From: Jes Sorensen >>> >>> Signed-off-by: Jes Sorensen >> >> You're compiling the nbd block driver out here. This is certainly not >> what you were attemp

Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects

2010-11-22 Thread Jes Sorensen
On 11/22/10 13:24, Kevin Wolf wrote: > Am 19.11.2010 17:30, schrieb jes.soren...@redhat.com: >> From: Jes Sorensen >> >> Signed-off-by: Jes Sorensen > > You're compiling the nbd block driver out here. This is certainly not > what you were attempting. (However, it's the only way to make it work,

Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects

2010-11-22 Thread Kevin Wolf
Am 19.11.2010 17:30, schrieb jes.soren...@redhat.com: > From: Jes Sorensen > > Signed-off-by: Jes Sorensen You're compiling the nbd block driver out here. This is certainly not what you were attempting. (However, it's the only way to make it work, because otherwise qemu-img will need the top-le

Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects

2010-11-21 Thread Jes Sorensen
On 11/20/10 18:22, Andreas Färber wrote: > Am 19.11.2010 um 17:30 schrieb jes.soren...@redhat.com: > >> From: Jes Sorensen >> >> Signed-off-by: Jes Sorensen >> --- >> Makefile |2 +- >> Makefile.objs | 12 ++-- >> 2 files changed, 11 insertions(+), 3 deletions(-) > > Tested-by:

Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects

2010-11-21 Thread Jes Sorensen
On 11/20/10 19:31, Stefan Hajnoczi wrote: > On Sat, Nov 20, 2010 at 6:04 PM, Andreas Färber > wrote: >> http://developer.apple.com/library/mac/#documentation/Darwin/Reference/ManPages/man3/daemon.3.html > > Deprecated in favor of using launchd. > > Removing qemu-nbd from the build because there

Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects

2010-11-20 Thread Stefan Hajnoczi
On Sat, Nov 20, 2010 at 6:04 PM, Andreas Färber wrote: > Am 20.11.2010 um 18:39 schrieb Stefan Hajnoczi: > >> On Sat, Nov 20, 2010 at 5:22 PM, Andreas Färber >> wrote: >>> >>> Any plans for a way to disable NBD build completely? There are warnings >>> about use of daemon() on Mac OS X and possibl

Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects

2010-11-20 Thread Andreas Färber
Am 20.11.2010 um 18:39 schrieb Stefan Hajnoczi: On Sat, Nov 20, 2010 at 5:22 PM, Andreas Färber > wrote: Any plans for a way to disable NBD build completely? There are warnings about use of daemon() on Mac OS X and possibly Solaris, and there's little point in building qemu-nbd if one does n

Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects

2010-11-20 Thread Stefan Hajnoczi
On Sat, Nov 20, 2010 at 5:22 PM, Andreas Färber wrote: > Any plans for a way to disable NBD build completely? There are warnings > about use of daemon() on Mac OS X and possibly Solaris, and there's little > point in building qemu-nbd if one does not use it. daemon() could be replaced by sharing

Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects

2010-11-20 Thread Andreas Färber
Am 19.11.2010 um 17:30 schrieb jes.soren...@redhat.com: From: Jes Sorensen Signed-off-by: Jes Sorensen --- Makefile |2 +- Makefile.objs | 12 ++-- 2 files changed, 11 insertions(+), 3 deletions(-) Tested-by: Andreas Färber Looks good to me and a clean build works okay.

[Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects

2010-11-19 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- Makefile |2 +- Makefile.objs | 12 ++-- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 747e47c..a503c1c 100644 --- a/Makefile +++ b/Makefile @@ -154,7 +154,7 @@ qemu-img.o qemu-tool