Re: [Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for internal snapshot

2016-01-13 Thread Markus Armbruster
Kevin Wolf writes: > Am 12.01.2016 um 18:40 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 12.01.2016 um 17:35 hat Denis V. Lunev geschrieben: >> >> On 01/12/2016 06:47 PM, Denis V. Lunev wrote: >> >> >On 01/12/2016 06:20 PM, Kevin Wolf

Re: [Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for internal snapshot

2016-01-13 Thread Laszlo Ersek
On 01/12/16 18:40, Markus Armbruster wrote: > Kevin Wolf writes: > >> Am 12.01.2016 um 17:35 hat Denis V. Lunev geschrieben: >>> On 01/12/2016 06:47 PM, Denis V. Lunev wrote: On 01/12/2016 06:20 PM, Kevin Wolf wrote: > Am 12.01.2016 um 15:59 hat Paolo Bonzini

Re: [Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for internal snapshot

2016-01-13 Thread Denis V. Lunev
On 01/13/2016 01:37 PM, Laszlo Ersek wrote: meta comment here: On 01/12/16 16:47, Denis V. Lunev wrote: P.S. Here is a summary that my colleague has receiver from libvirt list. Forwarded Message Subject: Re: Snapshotting OVMF guests Date: Mon, 11 Jan 2016 13:56:29

Re: [Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for internal snapshot

2016-01-13 Thread Laszlo Ersek
meta comment here: On 01/12/16 16:47, Denis V. Lunev wrote: > P.S. Here is a summary that my colleague has receiver from libvirt >list. > > Forwarded Message > Subject: Re: Snapshotting OVMF guests > Date: Mon, 11 Jan 2016 13:56:29 +0100 > From: Laszlo Ersek

Re: [Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for internal snapshot

2016-01-13 Thread Laszlo Ersek
On 01/12/16 18:50, Kevin Wolf wrote: > Am 12.01.2016 um 18:40 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >>> Am 12.01.2016 um 17:35 hat Denis V. Lunev geschrieben: On 01/12/2016 06:47 PM, Denis V. Lunev wrote: > On 01/12/2016 06:20 PM, Kevin Wolf wrote:

Re: [Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for internal snapshot

2016-01-13 Thread Laszlo Ersek
On 01/13/16 12:11, Denis V. Lunev wrote: > On 01/13/2016 01:37 PM, Laszlo Ersek wrote: >> meta comment here: >> >> On 01/12/16 16:47, Denis V. Lunev wrote: >> >>> P.S. Here is a summary that my colleague has receiver from libvirt >>> list. >>> >>> Forwarded Message >>>

Re: [Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for internal snapshot

2016-01-12 Thread Kevin Wolf
Am 12.01.2016 um 07:03 hat Denis V. Lunev geschrieben: > There is a long-long story. OVMF VMs can not be snapsotted using > 'virsh snapshot' as they have "pflash" device which is configured as > "raw" image. There was a discussion in the past about that. > > Good description has been provided on

Re: [Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for internal snapshot

2016-01-12 Thread Kevin Wolf
Am 12.01.2016 um 18:40 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 12.01.2016 um 17:35 hat Denis V. Lunev geschrieben: > >> On 01/12/2016 06:47 PM, Denis V. Lunev wrote: > >> >On 01/12/2016 06:20 PM, Kevin Wolf wrote: > >> >>Am 12.01.2016 um 15:59 hat Paolo

Re: [Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for internal snapshot

2016-01-12 Thread Denis V. Lunev
On 01/12/2016 08:50 PM, Kevin Wolf wrote: Am 12.01.2016 um 18:40 hat Markus Armbruster geschrieben: Kevin Wolf writes: Am 12.01.2016 um 17:35 hat Denis V. Lunev geschrieben: On 01/12/2016 06:47 PM, Denis V. Lunev wrote: On 01/12/2016 06:20 PM, Kevin Wolf wrote: Am

Re: [Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for internal snapshot

2016-01-12 Thread Denis V. Lunev
On 01/12/2016 08:40 PM, Markus Armbruster wrote: Kevin Wolf writes: Am 12.01.2016 um 17:35 hat Denis V. Lunev geschrieben: On 01/12/2016 06:47 PM, Denis V. Lunev wrote: On 01/12/2016 06:20 PM, Kevin Wolf wrote: Am 12.01.2016 um 15:59 hat Paolo Bonzini geschrieben: On

Re: [Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for internal snapshot

2016-01-12 Thread Denis V. Lunev
On 01/12/2016 05:59 PM, Paolo Bonzini wrote: On 12/01/2016 15:16, Kevin Wolf wrote: Thus we should avoid selection of "pflash" drives for VM state saving. For now "pflash" is read-write raw image as it configured by libvirt. Thus there are no such images in the field and we could safely

Re: [Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for internal snapshot

2016-01-12 Thread Peter Maydell
On 12 January 2016 at 15:13, Denis V. Lunev wrote: > The idea of this patch was trivial. First of all, I would like to keep > this image internally snapshoted. That is why the ultimate goal > was to switch from raw to qcow2 to keep changes inside the > image. > > Though in this

Re: [Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for internal snapshot

2016-01-12 Thread Paolo Bonzini
On 12/01/2016 15:16, Kevin Wolf wrote: >> Thus we should avoid selection of "pflash" drives for VM state saving. >> >> For now "pflash" is read-write raw image as it configured by libvirt. >> Thus there are no such images in the field and we could safely disable >> ability to save state to those

Re: [Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for internal snapshot

2016-01-12 Thread Denis V. Lunev
On 01/12/2016 05:16 PM, Kevin Wolf wrote: Am 12.01.2016 um 07:03 hat Denis V. Lunev geschrieben: There is a long-long story. OVMF VMs can not be snapsotted using 'virsh snapshot' as they have "pflash" device which is configured as "raw" image. There was a discussion in the past about that.

Re: [Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for internal snapshot

2016-01-12 Thread Paolo Bonzini
On 12/01/2016 16:20, Kevin Wolf wrote: > > Flash is already being snapshotted as part of saving RAM state. In > > fact, for this reason the device (at least the one used with OVMF; I > > haven't checked other pflash devices) can simply save it back to disk > > on the migration destination,

Re: [Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for internal snapshot

2016-01-12 Thread Kevin Wolf
Am 12.01.2016 um 15:59 hat Paolo Bonzini geschrieben: > > > On 12/01/2016 15:16, Kevin Wolf wrote: > >> Thus we should avoid selection of "pflash" drives for VM state saving. > >> > >> For now "pflash" is read-write raw image as it configured by libvirt. > >> Thus there are no such images in the

Re: [Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for internal snapshot

2016-01-12 Thread Kevin Wolf
Am 12.01.2016 um 16:16 hat Peter Maydell geschrieben: > On 12 January 2016 at 15:13, Denis V. Lunev wrote: > > The idea of this patch was trivial. First of all, I would like to keep > > this image internally snapshoted. That is why the ultimate goal > > was to switch from raw to

Re: [Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for internal snapshot

2016-01-12 Thread Kevin Wolf
Am 12.01.2016 um 16:10 hat Denis V. Lunev geschrieben: > On 01/12/2016 05:16 PM, Kevin Wolf wrote: > >Am 12.01.2016 um 07:03 hat Denis V. Lunev geschrieben: > >>There is a long-long story. OVMF VMs can not be snapsotted using > >>'virsh snapshot' as they have "pflash" device which is configured as

Re: [Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for internal snapshot

2016-01-12 Thread Denis V. Lunev
On 01/12/2016 06:20 PM, Kevin Wolf wrote: Am 12.01.2016 um 15:59 hat Paolo Bonzini geschrieben: On 12/01/2016 15:16, Kevin Wolf wrote: Thus we should avoid selection of "pflash" drives for VM state saving. For now "pflash" is read-write raw image as it configured by libvirt. Thus there are

Re: [Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for internal snapshot

2016-01-12 Thread Kevin Wolf
Am 12.01.2016 um 17:35 hat Denis V. Lunev geschrieben: > On 01/12/2016 06:47 PM, Denis V. Lunev wrote: > >On 01/12/2016 06:20 PM, Kevin Wolf wrote: > >>Am 12.01.2016 um 15:59 hat Paolo Bonzini geschrieben: > >>> > >>>On 12/01/2016 15:16, Kevin Wolf wrote: > >Thus we should avoid selection of

Re: [Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for internal snapshot

2016-01-12 Thread Denis V. Lunev
On 01/12/2016 07:52 PM, Kevin Wolf wrote: Am 12.01.2016 um 17:35 hat Denis V. Lunev geschrieben: On 01/12/2016 06:47 PM, Denis V. Lunev wrote: On 01/12/2016 06:20 PM, Kevin Wolf wrote: Am 12.01.2016 um 15:59 hat Paolo Bonzini geschrieben: On 12/01/2016 15:16, Kevin Wolf wrote: Thus we

Re: [Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for internal snapshot

2016-01-12 Thread Denis V. Lunev
On 01/12/2016 06:47 PM, Denis V. Lunev wrote: On 01/12/2016 06:20 PM, Kevin Wolf wrote: Am 12.01.2016 um 15:59 hat Paolo Bonzini geschrieben: On 12/01/2016 15:16, Kevin Wolf wrote: Thus we should avoid selection of "pflash" drives for VM state saving. For now "pflash" is read-write raw

Re: [Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for internal snapshot

2016-01-12 Thread Markus Armbruster
Kevin Wolf writes: > Am 12.01.2016 um 17:35 hat Denis V. Lunev geschrieben: >> On 01/12/2016 06:47 PM, Denis V. Lunev wrote: >> >On 01/12/2016 06:20 PM, Kevin Wolf wrote: >> >>Am 12.01.2016 um 15:59 hat Paolo Bonzini geschrieben: >> >>> >> >>>On 12/01/2016 15:16, Kevin Wolf

[Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for internal snapshot

2016-01-11 Thread Denis V. Lunev
There is a long-long story. OVMF VMs can not be snapsotted using 'virsh snapshot' as they have "pflash" device which is configured as "raw" image. There was a discussion in the past about that. Good description has been provided on topic by Laszlo Ersek, see below: "It is true that a pflash