Re: [Qemu-devel] [PATCH 1/1] block/file-posix.c: fix not reopened lock file descriptor

2018-03-29 Thread Fam Zheng
On Thu, 03/22 19:08, Dion Bosschieter wrote: > Yeah I have a use case, before a last sync on a storage migration we suspend a > VM -> send the last diffs -> mount the new storage server and after that we > change a symlink -> call reopen -> check if all file descriptors are changed > before resumin

Re: [Qemu-devel] [PATCH 1/1] block/file-posix.c: fix not reopened lock file descriptor

2018-03-29 Thread Fam Zheng
On Thu, 03/22 18:39, Kevin Wolf wrote: > [ Cc: qemu-block ] > > Am 22.03.2018 um 18:20 hat Dion Bosschieter geschrieben: > > In commit 244a5668106297378391b768e7288eb157616f64 another > > file descriptor to BDRVRawState is added. When we try to issue the > > reopen command only s->fd is reopened;

Re: [Qemu-devel] [PATCH 1/1] block/file-posix.c: fix not reopened lock file descriptor

2018-03-22 Thread Dion Bosschieter
Yeah I have a use case, before a last sync on a storage migration we suspend a VM -> send the last diffs -> mount the new storage server and after that we change a symlink -> call reopen -> check if all file descriptors are changed before resuming the VM. Dion > Op 22 mrt. 2018 om 18:39 heeft

[Qemu-devel] [PATCH 1/1] block/file-posix.c: fix not reopened lock file descriptor

2018-03-22 Thread Dion Bosschieter
In commit 244a5668106297378391b768e7288eb157616f64 another file descriptor to BDRVRawState is added. When we try to issue the reopen command only s->fd is reopened; lock_fd could still hold an old file descriptor "possibly" pointing to another file. - change raw_reopen_prepare so it checks use_loc

Re: [Qemu-devel] [PATCH 1/1] block/file-posix.c: fix not reopened lock file descriptor

2018-03-22 Thread Kevin Wolf
[ Cc: qemu-block ] Am 22.03.2018 um 18:20 hat Dion Bosschieter geschrieben: > In commit 244a5668106297378391b768e7288eb157616f64 another > file descriptor to BDRVRawState is added. When we try to issue the > reopen command only s->fd is reopened; lock_fd could still hold an old > file descriptor "