Re: [Qemu-devel] [PATCH 1/1] block: add block device shared field

2017-09-06 Thread Stefan Hajnoczi
On Tue, Sep 05, 2017 at 11:10:55AM -0400, Brian Steffens wrote: > > Have you considered extending the 'migrate' command with a list of > > drives instead? > > That was my original plan but I thought having information on whether a > device is shared or not could potentially be useful to other

Re: [Qemu-devel] [PATCH 1/1] block: add block device shared field

2017-09-05 Thread Fam Zheng
On Tue, 09/05 10:56, Stefan Hajnoczi wrote: > On Fri, Sep 01, 2017 at 08:10:54PM +, Brian Steffens wrote: > > This adds a boolean option called 'shared' to block devices. It defaults > > to off/false. When enabled for a particular block device, the 'shared' > > option > > causes the block

Re: [Qemu-devel] [PATCH 1/1] block: add block device shared field

2017-09-05 Thread Brian Steffens
Thanks for taking a look at the patch and fixing the missing CC addresses! > Have you considered extending the 'migrate' command with a list of > drives instead? That was my original plan but I thought having information on whether a device is shared or not could potentially be useful to other

Re: [Qemu-devel] [PATCH 1/1] block: add block device shared field

2017-09-05 Thread Stefan Hajnoczi
On Fri, Sep 01, 2017 at 08:10:54PM +, Brian Steffens wrote: > This adds a boolean option called 'shared' to block devices. It defaults > to off/false. When enabled for a particular block device, the 'shared' option > causes the block migration code to skip over syncing of that device. This >

Re: [Qemu-devel] [PATCH 1/1] block: add block device shared field

2017-09-01 Thread Eric Blake
On 09/01/2017 03:10 PM, Brian Steffens wrote: > This adds a boolean option called 'shared' to block devices. It defaults > to off/false. When enabled for a particular block device, the 'shared' option > causes the block migration code to skip over syncing of that device. This > allows controlling

[Qemu-devel] [PATCH 1/1] block: add block device shared field

2017-09-01 Thread Brian Steffens
This adds a boolean option called 'shared' to block devices. It defaults to off/false. When enabled for a particular block device, the 'shared' option causes the block migration code to skip over syncing of that device. This allows controlling exactly which block devices get synced during a