[Qemu-devel] [PATCH 1/1] migration: announce VM's new home just before VM is runnable

2015-10-14 Thread Amit Shah
We were announcing the dest host's IP as our new IP a bit too soon -- if there were errors detected after this announcement was done, the migration is failed and the VM could continue running on the src host -- causing problems later. Move around the qemu_announce_self() call so it's done just bef

Re: [Qemu-devel] [PATCH 1/1] migration: announce VM's new home just before VM is runnable

2015-10-14 Thread Michael S. Tsirkin
On Wed, Oct 14, 2015 at 05:37:19PM +0530, Amit Shah wrote: > We were announcing the dest host's IP as our new IP a bit too soon -- if > there were errors detected after this announcement was done, the > migration is failed and the VM could continue running on the src host -- > causing problems late

Re: [Qemu-devel] [PATCH 1/1] migration: announce VM's new home just before VM is runnable

2015-10-14 Thread Dr. David Alan Gilbert
* Amit Shah (amit.s...@redhat.com) wrote: > We were announcing the dest host's IP as our new IP a bit too soon -- if > there were errors detected after this announcement was done, the > migration is failed and the VM could continue running on the src host -- > causing problems later. > > Move arou

Re: [Qemu-devel] [PATCH 1/1] migration: announce VM's new home just before VM is runnable

2015-10-14 Thread Amit Shah
On (Wed) 14 Oct 2015 [13:38:30], Dr. David Alan Gilbert wrote: > * Amit Shah (amit.s...@redhat.com) wrote: > > We were announcing the dest host's IP as our new IP a bit too soon -- if > > there were errors detected after this announcement was done, the > > migration is failed and the VM could conti

Re: [Qemu-devel] [PATCH 1/1] migration: announce VM's new home just before VM is runnable

2015-10-14 Thread Juan Quintela
Amit Shah wrote: > We were announcing the dest host's IP as our new IP a bit too soon -- if > there were errors detected after this announcement was done, the > migration is failed and the VM could continue running on the src host -- > causing problems later. > > Move around the qemu_announce_self

Re: [Qemu-devel] [PATCH 1/1] migration: announce VM's new home just before VM is runnable

2015-10-14 Thread Michael S. Tsirkin
On Wed, Oct 14, 2015 at 03:21:15PM +0200, Juan Quintela wrote: > Amit Shah wrote: > > We were announcing the dest host's IP as our new IP a bit too soon -- if > > there were errors detected after this announcement was done, the > > migration is failed and the VM could continue running on the src h

Re: [Qemu-devel] [PATCH 1/1] migration: announce VM's new home just before VM is runnable

2015-10-14 Thread Jason Wang
On 10/14/2015 08:07 PM, Amit Shah wrote: > We were announcing the dest host's IP as our new IP a bit too soon -- if > there were errors detected after this announcement was done, the > migration is failed and the VM could continue running on the src host -- > causing problems later. > > Move arou

Re: [Qemu-devel] [PATCH 1/1] migration: announce VM's new home just before VM is runnable

2015-10-14 Thread Jason Wang
On 10/14/2015 10:12 PM, Michael S. Tsirkin wrote: > On Wed, Oct 14, 2015 at 03:21:15PM +0200, Juan Quintela wrote: >> Amit Shah wrote: >>> We were announcing the dest host's IP as our new IP a bit too soon -- if >>> there were errors detected after this announcement was done, the >>> migration i

Re: [Qemu-devel] [PATCH 1/1] migration: announce VM's new home just before VM is runnable

2015-10-14 Thread Amit Shah
On (Wed) 14 Oct 2015 [17:12:44], Michael S. Tsirkin wrote: > On Wed, Oct 14, 2015 at 03:21:15PM +0200, Juan Quintela wrote: > > Amit Shah wrote: > > > We were announcing the dest host's IP as our new IP a bit too soon -- if > > > there were errors detected after this announcement was done, the > >

Re: [Qemu-devel] [PATCH 1/1] migration: announce VM's new home just before VM is runnable

2015-10-14 Thread Juan Quintela
Amit Shah wrote: > On (Wed) 14 Oct 2015 [17:12:44], Michael S. Tsirkin wrote: >> On Wed, Oct 14, 2015 at 03:21:15PM +0200, Juan Quintela wrote: >> > Amit Shah wrote: >> > > We were announcing the dest host's IP as our new IP a bit too soon -- if >> > > there were errors detected after this announ

Re: [Qemu-devel] [PATCH 1/1] migration: announce VM's new home just before VM is runnable

2015-10-15 Thread Amit Shah
On (Thu) 15 Oct 2015 [08:36:49], Juan Quintela wrote: > Amit Shah wrote: > > On (Wed) 14 Oct 2015 [17:12:44], Michael S. Tsirkin wrote: > >> On Wed, Oct 14, 2015 at 03:21:15PM +0200, Juan Quintela wrote: > >> > Amit Shah wrote: > >> > > We were announcing the dest host's IP as our new IP a bit to

Re: [Qemu-devel] [PATCH 1/1] migration: announce VM's new home just before VM is runnable

2015-10-15 Thread Michael S. Tsirkin
On Thu, Oct 15, 2015 at 01:34:10PM +0530, Amit Shah wrote: > On (Thu) 15 Oct 2015 [08:36:49], Juan Quintela wrote: > > Amit Shah wrote: > > > On (Wed) 14 Oct 2015 [17:12:44], Michael S. Tsirkin wrote: > > >> On Wed, Oct 14, 2015 at 03:21:15PM +0200, Juan Quintela wrote: > > >> > Amit Shah wrote: