Re: [Qemu-devel] [PATCH 1/1] monitor: increase amount of data for monitor to read

2017-05-10 Thread Denis V. Lunev
On 05/10/2017 05:54 PM, Markus Armbruster wrote: > "Denis V. Lunev" writes: > >> On 05/03/2017 02:29 PM, Markus Armbruster wrote: >>> "Denis V. Lunev" writes: >>> On 05/02/2017 07:48 PM, Daniel P. Berrange wrote: > On Tue, May 02, 2017 at 05:36:30PM +0100, Dr. David Alan Gilbert wrote: >

Re: [Qemu-devel] [PATCH 1/1] monitor: increase amount of data for monitor to read

2017-05-10 Thread Markus Armbruster
"Denis V. Lunev" writes: > On 05/03/2017 02:29 PM, Markus Armbruster wrote: >> "Denis V. Lunev" writes: >> >>> On 05/02/2017 07:48 PM, Daniel P. Berrange wrote: On Tue, May 02, 2017 at 05:36:30PM +0100, Dr. David Alan Gilbert wrote: > * Markus Armbruster (arm...@redhat.com) wrote: >

Re: [Qemu-devel] [PATCH 1/1] monitor: increase amount of data for monitor to read

2017-05-03 Thread Denis V. Lunev
On 05/03/2017 02:29 PM, Markus Armbruster wrote: > "Denis V. Lunev" writes: > >> On 05/02/2017 07:48 PM, Daniel P. Berrange wrote: >>> On Tue, May 02, 2017 at 05:36:30PM +0100, Dr. David Alan Gilbert wrote: * Markus Armbruster (arm...@redhat.com) wrote: > "Denis V. Lunev" writes: > >

Re: [Qemu-devel] [PATCH 1/1] monitor: increase amount of data for monitor to read

2017-05-03 Thread Denis V. Lunev
On 05/03/2017 02:35 PM, Daniel P. Berrange wrote: > On Wed, May 03, 2017 at 01:29:57PM +0200, Markus Armbruster wrote: >> "Denis V. Lunev" writes: >> >>> On 05/02/2017 07:48 PM, Daniel P. Berrange wrote: On Tue, May 02, 2017 at 05:36:30PM +0100, Dr. David Alan Gilbert wrote: > * Markus Ar

Re: [Qemu-devel] [PATCH 1/1] monitor: increase amount of data for monitor to read

2017-05-03 Thread Marc-André Lureau
Hi On Wed, May 3, 2017 at 3:36 PM Daniel P. Berrange wrote: > On Wed, May 03, 2017 at 01:29:57PM +0200, Markus Armbruster wrote: > > > The only difference to before that I can see is that we can read ahead. > > That's a feature. > > > > Looks safe to me. Opinions? > > Yes, I concur, it looks sa

Re: [Qemu-devel] [PATCH 1/1] monitor: increase amount of data for monitor to read

2017-05-03 Thread Daniel P. Berrange
On Wed, May 03, 2017 at 01:29:57PM +0200, Markus Armbruster wrote: > "Denis V. Lunev" writes: > > > On 05/02/2017 07:48 PM, Daniel P. Berrange wrote: > >> On Tue, May 02, 2017 at 05:36:30PM +0100, Dr. David Alan Gilbert wrote: > >>> * Markus Armbruster (arm...@redhat.com) wrote: > "Denis V.

Re: [Qemu-devel] [PATCH 1/1] monitor: increase amount of data for monitor to read

2017-05-03 Thread Markus Armbruster
"Denis V. Lunev" writes: > On 05/02/2017 07:48 PM, Daniel P. Berrange wrote: >> On Tue, May 02, 2017 at 05:36:30PM +0100, Dr. David Alan Gilbert wrote: >>> * Markus Armbruster (arm...@redhat.com) wrote: "Denis V. Lunev" writes: > On 05/02/2017 05:43 PM, Markus Armbruster wrote: >>>

Re: [Qemu-devel] [PATCH 1/1] monitor: increase amount of data for monitor to read

2017-05-02 Thread Denis V. Lunev
On 05/02/2017 07:48 PM, Daniel P. Berrange wrote: > On Tue, May 02, 2017 at 05:36:30PM +0100, Dr. David Alan Gilbert wrote: >> * Markus Armbruster (arm...@redhat.com) wrote: >>> "Denis V. Lunev" writes: >>> On 05/02/2017 05:43 PM, Markus Armbruster wrote: > "Denis V. Lunev" writes: >

Re: [Qemu-devel] [PATCH 1/1] monitor: increase amount of data for monitor to read

2017-05-02 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Tue, May 02, 2017 at 05:36:30PM +0100, Dr. David Alan Gilbert wrote: > > * Markus Armbruster (arm...@redhat.com) wrote: > > > "Denis V. Lunev" writes: > > > > > > > On 05/02/2017 05:43 PM, Markus Armbruster wrote: > > > >> "Denis V. Lunev" w

Re: [Qemu-devel] [PATCH 1/1] monitor: increase amount of data for monitor to read

2017-05-02 Thread Daniel P. Berrange
On Tue, May 02, 2017 at 05:36:30PM +0100, Dr. David Alan Gilbert wrote: > * Markus Armbruster (arm...@redhat.com) wrote: > > "Denis V. Lunev" writes: > > > > > On 05/02/2017 05:43 PM, Markus Armbruster wrote: > > >> "Denis V. Lunev" writes: > > >> > > >>> Right now QMP and HMP monitors read 1 by

Re: [Qemu-devel] [PATCH 1/1] monitor: increase amount of data for monitor to read

2017-05-02 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Denis V. Lunev" writes: > > > On 05/02/2017 05:43 PM, Markus Armbruster wrote: > >> "Denis V. Lunev" writes: > >> > >>> Right now QMP and HMP monitors read 1 byte at a time from the socket, > >>> which > >>> is very inefficient. With 100+ VMs on

Re: [Qemu-devel] [PATCH 1/1] monitor: increase amount of data for monitor to read

2017-05-02 Thread Markus Armbruster
"Denis V. Lunev" writes: > On 05/02/2017 05:43 PM, Markus Armbruster wrote: >> "Denis V. Lunev" writes: >> >>> Right now QMP and HMP monitors read 1 byte at a time from the socket, which >>> is very inefficient. With 100+ VMs on the host this easily reasults in >>> a lot of unnecessary system ca

Re: [Qemu-devel] [PATCH 1/1] monitor: increase amount of data for monitor to read

2017-05-02 Thread Denis V. Lunev
On 05/02/2017 05:34 PM, Eric Blake wrote: > On 05/02/2017 08:47 AM, Denis V. Lunev wrote: >> Right now QMP and HMP monitors read 1 byte at a time from the socket, which >> is very inefficient. With 100+ VMs on the host this easily reasults in > s/reasults/results/ > >> a lot of unnecessary system c

Re: [Qemu-devel] [PATCH 1/1] monitor: increase amount of data for monitor to read

2017-05-02 Thread Denis V. Lunev
On 05/02/2017 05:43 PM, Markus Armbruster wrote: > "Denis V. Lunev" writes: > >> Right now QMP and HMP monitors read 1 byte at a time from the socket, which >> is very inefficient. With 100+ VMs on the host this easily reasults in >> a lot of unnecessary system calls and CPU usage in the system. >

Re: [Qemu-devel] [PATCH 1/1] monitor: increase amount of data for monitor to read

2017-05-02 Thread Daniel P. Berrange
On Tue, May 02, 2017 at 03:49:52PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Tue, May 02, 2017 at 09:34:55AM -0500, Eric Blake wrote: > > > On 05/02/2017 08:47 AM, Denis V. Lunev wrote: > > > > Right now QMP and HMP monitors read 1 byte at a tim

Re: [Qemu-devel] [PATCH 1/1] monitor: increase amount of data for monitor to read

2017-05-02 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Tue, May 02, 2017 at 09:34:55AM -0500, Eric Blake wrote: > > On 05/02/2017 08:47 AM, Denis V. Lunev wrote: > > > Right now QMP and HMP monitors read 1 byte at a time from the socket, > > > which > > > is very inefficient. With 100+ VMs on the

Re: [Qemu-devel] [PATCH 1/1] monitor: increase amount of data for monitor to read

2017-05-02 Thread Daniel P. Berrange
On Tue, May 02, 2017 at 09:34:55AM -0500, Eric Blake wrote: > On 05/02/2017 08:47 AM, Denis V. Lunev wrote: > > Right now QMP and HMP monitors read 1 byte at a time from the socket, which > > is very inefficient. With 100+ VMs on the host this easily reasults in > > s/reasults/results/ > > > a lo

Re: [Qemu-devel] [PATCH 1/1] monitor: increase amount of data for monitor to read

2017-05-02 Thread Markus Armbruster
"Denis V. Lunev" writes: > Right now QMP and HMP monitors read 1 byte at a time from the socket, which > is very inefficient. With 100+ VMs on the host this easily reasults in > a lot of unnecessary system calls and CPU usage in the system. > > This patch changes the amount of data to read to 409

Re: [Qemu-devel] [PATCH 1/1] monitor: increase amount of data for monitor to read

2017-05-02 Thread Eric Blake
On 05/02/2017 08:47 AM, Denis V. Lunev wrote: > Right now QMP and HMP monitors read 1 byte at a time from the socket, which > is very inefficient. With 100+ VMs on the host this easily reasults in s/reasults/results/ > a lot of unnecessary system calls and CPU usage in the system. > > This patch

[Qemu-devel] [PATCH 1/1] monitor: increase amount of data for monitor to read

2017-05-02 Thread Denis V. Lunev
Right now QMP and HMP monitors read 1 byte at a time from the socket, which is very inefficient. With 100+ VMs on the host this easily reasults in a lot of unnecessary system calls and CPU usage in the system. This patch changes the amount of data to read to 4096 bytes, which matches buffer size o