Re: [Qemu-devel] [PATCH 1/1] pci-host: add educational driver

2014-12-03 Thread Paolo Bonzini
On 03/12/2014 16:11, Jiri Slaby wrote: > On 10/13/2014, 03:00 PM, Paolo Bonzini wrote: >>> +static void edu_dma_timer(void *opaque) >>> +{ >>> + EduState *edu = opaque; >>> + bool raise_irq = false; >>> + >>> + qemu_mutex_lock(&edu->dma_mutex); >> >> dma_mutex and mutex and irq_mutex are no

Re: [Qemu-devel] [PATCH 1/1] pci-host: add educational driver

2014-12-03 Thread Jiri Slaby
On 10/13/2014, 03:00 PM, Paolo Bonzini wrote: >> +static void edu_dma_timer(void *opaque) >> +{ >> +EduState *edu = opaque; >> +bool raise_irq = false; >> + >> +qemu_mutex_lock(&edu->dma_mutex); > > dma_mutex and mutex and irq_mutex are not necessary. All I/O happens > under the big Q

Re: [Qemu-devel] [PATCH 1/1] pci-host: add educational driver

2014-10-13 Thread Paolo Bonzini
Il 13/10/2014 10:32, Jiri Slaby ha scritto: > No, the DMA addresses are on purpose 32-bit: to teach the people always > set the dma mask properly in the driver. This driver copies COMBO6x > devices (liberouter.org) behaviour which I used until the cards got > obsoleted (hard to find PCI-X slots now

Re: [Qemu-devel] [PATCH 1/1] pci-host: add educational driver

2014-10-13 Thread Paolo Bonzini
Il 10/10/2014 14:09, Jiri Slaby ha scritto: > I am using qemu for teaching the Linux kernel at our university. I > wrote a simple PCI device that can answer to writes/reads, generate > interrupts and perform DMA. As I am dragging it locally over 2 years, > I am sending it to you now. > > Signed-of

Re: [Qemu-devel] [PATCH 1/1] pci-host: add educational driver

2014-10-13 Thread Jiri Slaby
On 10/10/2014, 04:54 PM, Claudio Fontana wrote: > Hello, > > On 10.10.2014 14:09, Jiri Slaby wrote: >> I am using qemu for teaching the Linux kernel at our university. I >> wrote a simple PCI device that can answer to writes/reads, generate >> interrupts and perform DMA. As I am dragging it locall

Re: [Qemu-devel] [PATCH 1/1] pci-host: add educational driver

2014-10-10 Thread Claudio Fontana
Hello, On 10.10.2014 14:09, Jiri Slaby wrote: > I am using qemu for teaching the Linux kernel at our university. I > wrote a simple PCI device that can answer to writes/reads, generate > interrupts and perform DMA. As I am dragging it locally over 2 years, > I am sending it to you now. > > Signed

[Qemu-devel] [PATCH 1/1] pci-host: add educational driver

2014-10-10 Thread Jiri Slaby
I am using qemu for teaching the Linux kernel at our university. I wrote a simple PCI device that can answer to writes/reads, generate interrupts and perform DMA. As I am dragging it locally over 2 years, I am sending it to you now. Signed-off-by: Jiri Slaby --- MAINTAINERS | 5 +