Re: [Qemu-devel] [PATCH 1/1] qemu-img.c: Clean up handling of image size in img_create()

2010-12-08 Thread Jes Sorensen
On 12/08/10 09:54, Kevin Wolf wrote: > Am 07.12.2010 21:36, schrieb Stefan Hajnoczi: >> Today it is possible to create 0 byte sized images. Your patch will >> change that: >> If there is a backing file, then the size will be taken from the backing >> file. >> If there is no backing file, then an

Re: [Qemu-devel] [PATCH 1/1] qemu-img.c: Clean up handling of image size in img_create()

2010-12-08 Thread Kevin Wolf
Am 07.12.2010 21:36, schrieb Stefan Hajnoczi: > On Tue, Dec 7, 2010 at 5:39 PM, wrote: >> // The size for the image must always be specified, with one exception: >> // If we are using a backing file, we can obtain the size from there >> -if (get_option_parameter(param, BLOCK_OPT_SIZE)

Re: [Qemu-devel] [PATCH 1/1] qemu-img.c: Clean up handling of image size in img_create()

2010-12-07 Thread Jes Sorensen
On 12/07/10 21:36, Stefan Hajnoczi wrote: > On Tue, Dec 7, 2010 at 5:39 PM, wrote: >> // The size for the image must always be specified, with one exception: >> // If we are using a backing file, we can obtain the size from there >> -if (get_option_parameter(param, BLOCK_OPT_SIZE)->va

Re: [Qemu-devel] [PATCH 1/1] qemu-img.c: Clean up handling of image size in img_create()

2010-12-07 Thread Stefan Hajnoczi
On Tue, Dec 7, 2010 at 5:39 PM, wrote: >     // The size for the image must always be specified, with one exception: >     // If we are using a backing file, we can obtain the size from there > -    if (get_option_parameter(param, BLOCK_OPT_SIZE)->value.n == -1) { > - > +    if (get_option_parame

[Qemu-devel] [PATCH 1/1] qemu-img.c: Clean up handling of image size in img_create()

2010-12-07 Thread Jes . Sorensen
From: Jes Sorensen This cleans up the handling of image size in img_create() by parsing the value early, and then only setting it once if a value has been added as the last argument to the command line. Signed-off-by: Jes Sorensen --- qemu-img.c | 19 +++ 1 files changed, 11