Re: [Qemu-devel] [PATCH 1/1 V6] qemu-kvm: fix improper nmi emulation

2011-12-08 Thread Jan Kiszka
On 2011-12-07 11:29, Avi Kivity wrote: On 10/17/2011 06:00 PM, Lai Jiangshan wrote: From: Lai Jiangshan la...@cn.fujitsu.com Currently, NMI interrupt is blindly sent to all the vCPUs when NMI button event happens. This doesn't properly emulate real hardware on which NMI button event triggers

Re: [Qemu-devel] [PATCH 1/1 V6] qemu-kvm: fix improper nmi emulation

2011-12-08 Thread Jan Kiszka
On 2011-12-08 10:42, Jan Kiszka wrote: On 2011-12-07 11:29, Avi Kivity wrote: On 10/17/2011 06:00 PM, Lai Jiangshan wrote: From: Lai Jiangshan la...@cn.fujitsu.com Currently, NMI interrupt is blindly sent to all the vCPUs when NMI button event happens. This doesn't properly emulate real

Re: [Qemu-devel] [PATCH 1/1 V6] qemu-kvm: fix improper nmi emulation

2011-12-07 Thread Avi Kivity
On 10/17/2011 06:00 PM, Lai Jiangshan wrote: From: Lai Jiangshan la...@cn.fujitsu.com Currently, NMI interrupt is blindly sent to all the vCPUs when NMI button event happens. This doesn't properly emulate real hardware on which NMI button event triggers LINT1. Because of this, NMI is sent to

Re: [Qemu-devel] [PATCH 1/1 V6] qemu-kvm: fix improper nmi emulation

2011-10-19 Thread Lai Jiangshan
On 10/19/2011 03:41 AM, Jan Kiszka wrote: On 2011-10-17 18:00, Lai Jiangshan wrote: On 10/17/2011 05:49 PM, Avi Kivity wrote: On 10/17/2011 11:40 AM, Lai Jiangshan wrote: LINT1 may have been programmed as a level -triggered interrupt instead of edge triggered (NMI or interrupt). We can use

Re: [Qemu-devel] [PATCH 1/1 V6] qemu-kvm: fix improper nmi emulation

2011-10-19 Thread Avi Kivity
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/18/2011 09:41 PM, Jan Kiszka wrote: Looks OK to me. Same here. - -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux)

Re: [Qemu-devel] [PATCH 1/1 V6] qemu-kvm: fix improper nmi emulation

2011-10-19 Thread Jan Kiszka
On 2011-10-19 08:33, Lai Jiangshan wrote: On 10/19/2011 03:41 AM, Jan Kiszka wrote: On 2011-10-17 18:00, Lai Jiangshan wrote: On 10/17/2011 05:49 PM, Avi Kivity wrote: On 10/17/2011 11:40 AM, Lai Jiangshan wrote: LINT1 may have been programmed as a level -triggered interrupt instead of

Re: [Qemu-devel] [PATCH 1/1 V6] qemu-kvm: fix improper nmi emulation

2011-10-19 Thread Lai Jiangshan
On 10/19/2011 05:29 PM, Avi Kivity wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/18/2011 09:41 PM, Jan Kiszka wrote: Looks OK to me. Same here. Who will merge it? Thanks, Lai - -- I have a truly marvellous patch that fixes the bug which this signature is too

Re: [Qemu-devel] [PATCH 1/1 V6] qemu-kvm: fix improper nmi emulation

2011-10-18 Thread Jan Kiszka
On 2011-10-17 18:00, Lai Jiangshan wrote: On 10/17/2011 05:49 PM, Avi Kivity wrote: On 10/17/2011 11:40 AM, Lai Jiangshan wrote: LINT1 may have been programmed as a level -triggered interrupt instead of edge triggered (NMI or interrupt). We can use the ioctl argument for the level (and

[Qemu-devel] [PATCH 1/1 V6] qemu-kvm: fix improper nmi emulation

2011-10-17 Thread Lai Jiangshan
On 10/17/2011 05:49 PM, Avi Kivity wrote: On 10/17/2011 11:40 AM, Lai Jiangshan wrote: LINT1 may have been programmed as a level -triggered interrupt instead of edge triggered (NMI or interrupt). We can use the ioctl argument for the level (and pressing the NMI button needs to pulse the