Re: [Qemu-devel] [PATCH 1/2] [RFC] arm_gic_common.h: add gicv2 aliases for defines

2015-10-11 Thread Pavel Fedin
Hi! > It looks like the only thing in the gicv3 code that is using > a define from the arm_gic_common.h file is "GIC_INTERNAL", > so we can just put a suitable define of that into the v3 header > (maybe giving it a better name in the process). Yes, indeed. Actually, first versions of my GICv3 p

Re: [Qemu-devel] [PATCH 1/2] [RFC] arm_gic_common.h: add gicv2 aliases for defines

2015-10-09 Thread Peter Maydell
On 6 October 2015 at 15:37, Andrew Jones wrote: > I'm not sure if arm_gic_common.h is supposed to be common, not > only between tcg and kvm, but also v2 and v3, but it currently > is (arm_gicv3_common.h includes it, and it's the only gic header > included by hw/arm/virt.c). I don't think it shoul

[Qemu-devel] [PATCH 1/2] [RFC] arm_gic_common.h: add gicv2 aliases for defines

2015-10-06 Thread Andrew Jones
I'm not sure if arm_gic_common.h is supposed to be common, not only between tcg and kvm, but also v2 and v3, but it currently is (arm_gicv3_common.h includes it, and it's the only gic header included by hw/arm/virt.c). If it should be the super-common header, then it's unfortunate that the define n