Re: [Qemu-devel] [PATCH 1/2] ACPI: Add definitions for the SPCR table

2015-06-09 Thread Shannon Zhao
Hi Andrew, Some minor comments below. Use scripts/checkpatch.pl before submitting. On 2015/6/8 22:00, Andrew Jones wrote: SPCR is the Serial Port Console Redirection table. See the document linked from http://uefi.org/acpi. For serial port types, Interface Type, see the documentation for the

Re: [Qemu-devel] [PATCH 1/2] ACPI: Add definitions for the SPCR table

2015-06-09 Thread Michael S. Tsirkin
On Mon, Jun 08, 2015 at 10:00:49AM -0400, Andrew Jones wrote: SPCR is the Serial Port Console Redirection table. See the document linked from http://uefi.org/acpi. For serial port types, Interface Type, see the documentation for the Debug Port Table 2 (DBG2). Signed-off-by: Andrew Jones

Re: [Qemu-devel] [PATCH 1/2] ACPI: Add definitions for the SPCR table

2015-06-09 Thread Andrew Jones
On Tue, Jun 09, 2015 at 04:52:39PM +0200, Michael S. Tsirkin wrote: On Mon, Jun 08, 2015 at 10:00:49AM -0400, Andrew Jones wrote: SPCR is the Serial Port Console Redirection table. See the document linked from http://uefi.org/acpi. For serial port types, Interface Type, see the

Re: [Qemu-devel] [PATCH 1/2] ACPI: Add definitions for the SPCR table

2015-06-09 Thread Michael S. Tsirkin
On Tue, Jun 09, 2015 at 07:03:04PM +0200, Andrew Jones wrote: On Tue, Jun 09, 2015 at 04:52:39PM +0200, Michael S. Tsirkin wrote: On Mon, Jun 08, 2015 at 10:00:49AM -0400, Andrew Jones wrote: SPCR is the Serial Port Console Redirection table. See the document linked from

[Qemu-devel] [PATCH 1/2] ACPI: Add definitions for the SPCR table

2015-06-08 Thread Andrew Jones
SPCR is the Serial Port Console Redirection table. See the document linked from http://uefi.org/acpi. For serial port types, Interface Type, see the documentation for the Debug Port Table 2 (DBG2). Signed-off-by: Andrew Jones drjo...@redhat.com --- include/hw/acpi/acpi-defs.h | 72