Re: [Qemu-devel] [PATCH 1/2] When the XHCI host controller is switched to the running mode, set the ccs bit for each port, to which a device is already attached.

2012-11-01 Thread Gerd Hoffmann
Hi, [ sorry for the delay, was busy with other stuff ] > I'm not sure about that. According to the spec, when the hc is set to > running mode (p.70) > > "At this point, the host controller is up and running and the Root Hub > ports (5.4.8) will begin reporting device > connects" I understand

Re: [Qemu-devel] [PATCH 1/2] When the XHCI host controller is switched to the running mode, set the ccs bit for each port, to which a device is already attached.

2012-10-26 Thread Sebastian Bauer
Hi! Am 26.10.2012 14:00, schrieb Gerd Hoffmann: Wrong fix I think. Just moving "port->portsc |= PORTSC_CSC" out of the "if (running)" should do. usb-next already has a patch which fixes this: I'm not sure about that. According to the spec, when the hc is set to running mode (p.70) "At th

Re: [Qemu-devel] [PATCH 1/2] When the XHCI host controller is switched to the running mode, set the ccs bit for each port, to which a device is already attached.

2012-10-26 Thread Gerd Hoffmann
On 10/26/12 10:29, Sebastian Bauer wrote: Wrong fix I think. Just moving "port->portsc |= PORTSC_CSC" out of the "if (running)" should do. usb-next already has a patch which fixes this: http://www.kraxel.org/cgit/qemu/commit/?h=rebase/usb-next&id=84f84686c701731964a515e9bbcfb475cfc1de8c cheers

[Qemu-devel] [PATCH 1/2] When the XHCI host controller is switched to the running mode, set the ccs bit for each port, to which a device is already attached.

2012-10-26 Thread Sebastian Bauer
--- hw/usb/hcd-xhci.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 37b3dbb..4c81dcc 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -990,10 +990,29 @@ static void xhci_er_reset(XHCIState *xhci