Re: [Qemu-devel] [PATCH 1/2] add VirtIONet vhost_stopped flag to prevent multiple stops

2019-04-24 Thread Jason Wang
On 2019/4/23 下午4:49, Dan Streetman wrote: I think so if net_vhost_user_event() was called in main thread (it calls qemu_get_current_aio_context()). ok, I'll check that, thanks! I think my other patch, to remove the vhost_user_stop() call completely from the net_vhost_user_event() handler for

Re: [Qemu-devel] [PATCH 1/2] add VirtIONet vhost_stopped flag to prevent multiple stops

2019-04-23 Thread Dan Streetman
On Mon, Apr 22, 2019 at 10:59 PM Jason Wang wrote: > > > On 2019/4/23 上午4:14, Dan Streetman wrote: > > On Sun, Apr 21, 2019 at 10:50 PM Jason Wang wrote: > >> > >> On 2019/4/17 上午2:46, Dan Streetman wrote: > >>> From: Dan Streetman > >>> > >>> Buglink: https://launchpad.net/bugs/1823458 > >>> >

Re: [Qemu-devel] [PATCH 1/2] add VirtIONet vhost_stopped flag to prevent multiple stops

2019-04-22 Thread Jason Wang
On 2019/4/23 上午4:14, Dan Streetman wrote: On Sun, Apr 21, 2019 at 10:50 PM Jason Wang wrote: On 2019/4/17 上午2:46, Dan Streetman wrote: From: Dan Streetman Buglink: https://launchpad.net/bugs/1823458 There is a race condition when using the vhost-user driver, between a guest shutdown and

Re: [Qemu-devel] [PATCH 1/2] add VirtIONet vhost_stopped flag to prevent multiple stops

2019-04-22 Thread Dan Streetman
On Fri, Apr 19, 2019 at 7:14 PM Michael S. Tsirkin wrote: > > On Tue, Apr 16, 2019 at 02:46:23PM -0400, Dan Streetman wrote: > > From: Dan Streetman > > > > Buglink: https://launchpad.net/bugs/1823458 > > > > There is a race condition when using the vhost-user driver, between a guest > > shutdown

Re: [Qemu-devel] [PATCH 1/2] add VirtIONet vhost_stopped flag to prevent multiple stops

2019-04-22 Thread Dan Streetman
On Sun, Apr 21, 2019 at 10:50 PM Jason Wang wrote: > > > On 2019/4/17 上午2:46, Dan Streetman wrote: > > From: Dan Streetman > > > > Buglink: https://launchpad.net/bugs/1823458 > > > > There is a race condition when using the vhost-user driver, between a guest > > shutdown and the vhost-user interf

Re: [Qemu-devel] [PATCH 1/2] add VirtIONet vhost_stopped flag to prevent multiple stops

2019-04-21 Thread Jason Wang
On 2019/4/17 上午2:46, Dan Streetman wrote: From: Dan Streetman Buglink: https://launchpad.net/bugs/1823458 There is a race condition when using the vhost-user driver, between a guest shutdown and the vhost-user interface being closed. This is explained in more detail at the bug link above; t

Re: [Qemu-devel] [PATCH 1/2] add VirtIONet vhost_stopped flag to prevent multiple stops

2019-04-19 Thread Michael S. Tsirkin
On Tue, Apr 16, 2019 at 02:46:23PM -0400, Dan Streetman wrote: > From: Dan Streetman > > Buglink: https://launchpad.net/bugs/1823458 > > There is a race condition when using the vhost-user driver, between a guest > shutdown and the vhost-user interface being closed. This is explained in > more

[Qemu-devel] [PATCH 1/2] add VirtIONet vhost_stopped flag to prevent multiple stops

2019-04-16 Thread Dan Streetman
From: Dan Streetman Buglink: https://launchpad.net/bugs/1823458 There is a race condition when using the vhost-user driver, between a guest shutdown and the vhost-user interface being closed. This is explained in more detail at the bug link above; the short explanation is the vhost-user device