Re: [Qemu-devel] [PATCH 1/2] avoid to allcate used macaddr to to new nic

2013-06-17 Thread Michael S. Tsirkin
On Tue, Jun 18, 2013 at 10:05:58AM +0800, Fam Zheng wrote: > On Mon, 06/17 17:00, Michael S. Tsirkin wrote: > > On Mon, Jun 17, 2013 at 09:35:10PM +0800, Amos Kong wrote: > > > QEMU allocates macaddr to nic if user doesn't assigne macaddr. > > > But we didn't check if the allocated macaddr is used,

Re: [Qemu-devel] [PATCH 1/2] avoid to allcate used macaddr to to new nic

2013-06-17 Thread Fam Zheng
On Mon, 06/17 17:00, Michael S. Tsirkin wrote: > On Mon, Jun 17, 2013 at 09:35:10PM +0800, Amos Kong wrote: > > QEMU allocates macaddr to nic if user doesn't assigne macaddr. > > But we didn't check if the allocated macaddr is used, it might > > cause macaddr repeated. > > > > # qemu -device e100

Re: [Qemu-devel] [PATCH 1/2] avoid to allcate used macaddr to to new nic

2013-06-17 Thread Michael S. Tsirkin
On Mon, Jun 17, 2013 at 09:35:10PM +0800, Amos Kong wrote: > QEMU allocates macaddr to nic if user doesn't assigne macaddr. > But we didn't check if the allocated macaddr is used, it might > cause macaddr repeated. > > # qemu -device e1000,netdev=h1,mac=52:54:00:12:34:56 > (qemu) device_add e10

[Qemu-devel] [PATCH 1/2] avoid to allcate used macaddr to to new nic

2013-06-17 Thread Amos Kong
QEMU allocates macaddr to nic if user doesn't assigne macaddr. But we didn't check if the allocated macaddr is used, it might cause macaddr repeated. # qemu -device e1000,netdev=h1,mac=52:54:00:12:34:56 (qemu) device_add e1000 (qemu) info network e1000.0: index=0,type=nic,model=e1000,macadd