Re: [Qemu-devel] [PATCH 1/2] block/mirror: Make cancel always cancel pre-READY

2018-05-02 Thread Max Reitz
On 2018-05-02 01:31, Eric Blake wrote: > On 05/01/2018 05:05 PM, Max Reitz wrote: >> Commit b76e4458b1eb3c32e9824fe6aa51f67d2b251748 made the mirror block >> job respect block-job-cancel's @force flag: With that flag set, it would >> now always really cancel, even post-READY. >> >> Unfortunately, i

Re: [Qemu-devel] [PATCH 1/2] block/mirror: Make cancel always cancel pre-READY

2018-05-01 Thread Eric Blake
On 05/01/2018 05:05 PM, Max Reitz wrote: Commit b76e4458b1eb3c32e9824fe6aa51f67d2b251748 made the mirror block job respect block-job-cancel's @force flag: With that flag set, it would now always really cancel, even post-READY. Unfortunately, it had a side effect: Without that flag set, it would

[Qemu-devel] [PATCH 1/2] block/mirror: Make cancel always cancel pre-READY

2018-05-01 Thread Max Reitz
Commit b76e4458b1eb3c32e9824fe6aa51f67d2b251748 made the mirror block job respect block-job-cancel's @force flag: With that flag set, it would now always really cancel, even post-READY. Unfortunately, it had a side effect: Without that flag set, it would now never cancel, not even before READY. C