Re: [Qemu-devel] [PATCH 1/2] block: allow live commit of active image

2013-07-23 Thread Paolo Bonzini
Il 23/07/2013 04:03, Fam Zheng ha scritto: >> > stop >> > block-job-complete ide0-hd0 >> > cont >> > > I see, this way the job needs to stop vm in the point of all copying > drained, then report 'ready' and wait for manual complete before > swapping active, sounds not so good. Ideally

Re: [Qemu-devel] [PATCH 1/2] block: allow live commit of active image

2013-07-22 Thread Fam Zheng
On Mon, 07/22 13:07, Paolo Bonzini wrote: > Il 22/07/2013 08:48, Fam Zheng ha scritto: > >> > I have only skimmed the patch, but I think this is incomplete. > >> > Management needs to know the moment when 'active' is not valid anymore, > >> > thus this job needs to be completed manually with "block

Re: [Qemu-devel] [PATCH 1/2] block: allow live commit of active image

2013-07-22 Thread Paolo Bonzini
Il 22/07/2013 08:48, Fam Zheng ha scritto: >> > I have only skimmed the patch, but I think this is incomplete. >> > Management needs to know the moment when 'active' is not valid anymore, >> > thus this job needs to be completed manually with "block-job-complete". > Does management need access to '

Re: [Qemu-devel] [PATCH 1/2] block: allow live commit of active image

2013-07-21 Thread Fam Zheng
On Mon, 07/22 08:34, Paolo Bonzini wrote: > Il 22/07/2013 05:46, Fam Zheng ha scritto: > > This patch eliminates limitation of committing the active device. > > > > bdrv_drop_intermediate is reimplemented to take pointers to > > (BlockDriverState *), so it can modify the caller's local pointers to

Re: [Qemu-devel] [PATCH 1/2] block: allow live commit of active image

2013-07-21 Thread Paolo Bonzini
Il 22/07/2013 05:46, Fam Zheng ha scritto: > This patch eliminates limitation of committing the active device. > > bdrv_drop_intermediate is reimplemented to take pointers to > (BlockDriverState *), so it can modify the caller's local pointers to > preserve their semantics, while updating active B

[Qemu-devel] [PATCH 1/2] block: allow live commit of active image

2013-07-21 Thread Fam Zheng
This patch eliminates limitation of committing the active device. bdrv_drop_intermediate is reimplemented to take pointers to (BlockDriverState *), so it can modify the caller's local pointers to preserve their semantics, while updating active BDS in-place by bdrv_swap active and base: we need dat