Re: [Qemu-devel] [PATCH 1/2] cpu-defs.h: Document CPUIOTLBEntry 'addr' field

2018-06-12 Thread Emilio G. Cota
On Mon, Jun 11, 2018 at 13:56:32 +0100, Peter Maydell wrote: > typedef struct CPUIOTLBEntry { > +/* > + * @addr contains: > + * - in the lower TARGET_PAGE_BITS, a physical section number > + * - with the lower TARGET_PAGE_BITS masked off, an offset which > + *must be adde

Re: [Qemu-devel] [PATCH 1/2] cpu-defs.h: Document CPUIOTLBEntry 'addr' field

2018-06-12 Thread Richard Henderson
On 06/11/2018 02:56 AM, Peter Maydell wrote: > The 'addr' field in the CPUIOTLBEntry struct has a rather non-obvious > use; add a comment documenting it (reverse-engineered from what > the code that sets it is doing). > > Signed-off-by: Peter Maydell > --- > include/exec/cpu-defs.h | 9

[Qemu-devel] [PATCH 1/2] cpu-defs.h: Document CPUIOTLBEntry 'addr' field

2018-06-11 Thread Peter Maydell
The 'addr' field in the CPUIOTLBEntry struct has a rather non-obvious use; add a comment documenting it (reverse-engineered from what the code that sets it is doing). Signed-off-by: Peter Maydell --- include/exec/cpu-defs.h | 9 + accel/tcg/cputlb.c | 12 2 files chang