Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit()

On Wed, Aug 17, 2016 at 11:26:51AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Tue, Aug 16, 2016 at 08:17:08PM +0800, Peter Xu wrote: > >> > > > >> > > Also, please make it a function, not a macro: > >> > > > >> > > void error_report_fatal(const char

Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit()

Peter Xu writes: > On Tue, Aug 16, 2016 at 08:17:08PM +0800, Peter Xu wrote: >> > > >> > > Also, please make it a function, not a macro: >> > > >> > > void error_report_fatal(const char *fmt, ...) >> > > { >> > > va_list ap; >> > > >> > >

Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit()

On Tue, Aug 16, 2016 at 08:17:08PM +0800, Peter Xu wrote: > > > > > > Also, please make it a function, not a macro: > > > > > > void error_report_fatal(const char *fmt, ...) > > > { > > > va_list ap; > > > > > > va_start(ap, fmt); > > > error_vreport(fmt, ap); >

Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit()

On Wed, Aug 17, 2016 at 09:33:37AM +0200, Markus Armbruster wrote: > > Yes I see usages for error_setg(_abort, ...), it makes sense to > > provide error_report_abort() along with error_report_fatal(). Will > > take your (and Fam's) advice. > > Recommend to make it a separate patch. Will do. --

Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit()

Peter Xu writes: > On Tue, Aug 16, 2016 at 04:45:13PM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > On Tue, Aug 16, 2016 at 08:19:08PM +0800, Fam Zheng wrote: >> >> On Tue, 08/16 20:17, Peter Xu wrote: >> >> > > Do we really need

Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit()

On Tue, Aug 16, 2016 at 04:45:13PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Tue, Aug 16, 2016 at 08:19:08PM +0800, Fam Zheng wrote: > >> On Tue, 08/16 20:17, Peter Xu wrote: > >> > > Do we really need error_report_exit when we already have error_fatal? > >>

Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit()

Peter Xu writes: > On Tue, Aug 16, 2016 at 08:19:08PM +0800, Fam Zheng wrote: >> On Tue, 08/16 20:17, Peter Xu wrote: >> > > Do we really need error_report_exit when we already have error_fatal? >> > >> > error_fatal is the name of a global var, not the function. >> >> I

Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit()

On Tue, 08/16 22:00, Peter Xu wrote: > On Tue, Aug 16, 2016 at 08:19:08PM +0800, Fam Zheng wrote: > > On Tue, 08/16 20:17, Peter Xu wrote: > > > > Do we really need error_report_exit when we already have error_fatal? > > > > > > error_fatal is the name of a global var, not the function. > > > >

Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit()

On Tue, Aug 16, 2016 at 08:19:08PM +0800, Fam Zheng wrote: > On Tue, 08/16 20:17, Peter Xu wrote: > > > Do we really need error_report_exit when we already have error_fatal? > > > > error_fatal is the name of a global var, not the function. > > I mean most error_report_exit(...) calls can be

Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit()

On Tue, 08/16 20:17, Peter Xu wrote: > > Do we really need error_report_exit when we already have error_fatal? > > error_fatal is the name of a global var, not the function. I mean most error_report_exit(...) calls can be converted to error_setg(_fatal, ...). Fam

Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit()

On Tue, Aug 16, 2016 at 07:53:51PM +0800, Fam Zheng wrote: > On Tue, 08/16 13:05, Markus Armbruster wrote: > > Peter Xu writes: > > > > > There are many places in current QEMU codes that needs to print some > > > error and then quit QEMU. Provide a macro for it. > > > > > >

Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit()

On Tue, 08/16 13:05, Markus Armbruster wrote: > Peter Xu writes: > > > There are many places in current QEMU codes that needs to print some > > error and then quit QEMU. Provide a macro for it. > > > > Also, one coccinelle script is added to convert existing cases to > >

Re: [Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit()

Peter Xu writes: > There are many places in current QEMU codes that needs to print some > error and then quit QEMU. Provide a macro for it. > > Also, one coccinelle script is added to convert existing cases to > leverage this new macro. > > Signed-off-by: Peter Xu

[Qemu-devel] [PATCH 1/2] error-report: provide error_report_exit()

There are many places in current QEMU codes that needs to print some error and then quit QEMU. Provide a macro for it. Also, one coccinelle script is added to convert existing cases to leverage this new macro. Signed-off-by: Peter Xu --- include/qemu/error-report.h