Re: [Qemu-devel] [PATCH 1/2] hw/exynos4210_gic.c: Introduce n_in and n_out propeties.

2012-04-12 Thread Peter Maydell
On 12 April 2012 04:23, Evgeny Voevodin wrote: > On 11.04.2012 19:17, Peter Maydell wrote: >> >> The right way to check for validity of properties in the init >> function is to use hw_error() with a reasonably friendly message. >> > > Ok! What's about irq handlers? Is assert() possible? Yes, asse

Re: [Qemu-devel] [PATCH 1/2] hw/exynos4210_gic.c: Introduce n_in and n_out propeties.

2012-04-11 Thread Evgeny Voevodin
On 11.04.2012 19:17, Peter Maydell wrote: On 11 April 2012 08:48, Evgeny Voevodin wrote: With these properties irq gate could be tuned to mux up to QDEV_MAX_IRQ inputs and ouputs. Gate will group inputs into groups of size n_in/n_out each. Signed-off-by: Evgeny Voevodin --- hw/exynos4210_gic

Re: [Qemu-devel] [PATCH 1/2] hw/exynos4210_gic.c: Introduce n_in and n_out propeties.

2012-04-11 Thread Peter Maydell
On 11 April 2012 08:48, Evgeny Voevodin wrote: > With these properties irq gate could be tuned to mux up to > QDEV_MAX_IRQ inputs and ouputs. Gate will group inputs > into groups of size n_in/n_out each. > > Signed-off-by: Evgeny Voevodin > --- >  hw/exynos4210_gic.c |   60 ++

[Qemu-devel] [PATCH 1/2] hw/exynos4210_gic.c: Introduce n_in and n_out propeties.

2012-04-11 Thread Evgeny Voevodin
With these properties irq gate could be tuned to mux up to QDEV_MAX_IRQ inputs and ouputs. Gate will group inputs into groups of size n_in/n_out each. Signed-off-by: Evgeny Voevodin --- hw/exynos4210_gic.c | 60 -- 1 files changed, 38 insertions(

Re: [Qemu-devel] [PATCH 1/2] hw/exynos4210_gic.c: Introduce n_in and n_out propeties.

2012-04-11 Thread Evgeny Voevodin
On 11.04.2012 11:18, Evgeny Voevodin wrote: With these properties irq gate could be tuned to mux up to QDEV_MAX_IRQ inputs and ouputs. Gate will group inputs into groups of size n_out / n_in each. Oops, incorrect comment. Will send new patch. Signed-off-by: Evgeny Voevodin --- hw/exynos421

[Qemu-devel] [PATCH 1/2] hw/exynos4210_gic.c: Introduce n_in and n_out propeties.

2012-04-11 Thread Evgeny Voevodin
With these properties irq gate could be tuned to mux up to QDEV_MAX_IRQ inputs and ouputs. Gate will group inputs into groups of size n_out / n_in each. Signed-off-by: Evgeny Voevodin --- hw/exynos4210_gic.c | 60 -- 1 files changed, 38 insertion