Re: [Qemu-devel] [PATCH 1/2] hw/sd: implement CMD23 (SET_BLOCK_COUNT) for MMC compatibility

2015-12-06 Thread Peter Crosthwaite
On Sun, Dec 6, 2015 at 1:20 PM, Andrew Baumann wrote: >> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] >> Sent: Saturday, 5 December 2015 22:27 >> On Fri, Dec 4, 2015 at 1:16 PM, Andrew Baumann >> wrote: >> > @@ -1563,6

Re: [Qemu-devel] [PATCH 1/2] hw/sd: implement CMD23 (SET_BLOCK_COUNT) for MMC compatibility

2015-12-06 Thread Andrew Baumann
> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Saturday, 5 December 2015 22:27 > On Fri, Dec 4, 2015 at 1:16 PM, Andrew Baumann > wrote: > > @@ -1563,6 +1592,11 @@ void sd_write_data(SDState *sd, uint8_t value) > > sd->data_offset

Re: [Qemu-devel] [PATCH 1/2] hw/sd: implement CMD23 (SET_BLOCK_COUNT) for MMC compatibility

2015-12-06 Thread Peter Crosthwaite
On Sun, Dec 6, 2015 at 10:03 PM, Andrew Baumann wrote: > Hi Peter, > >> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] >> Sent: Sunday, 6 December 2015 15:47 >> On Sun, Dec 6, 2015 at 1:20 PM, Andrew Baumann >> wrote: >> >>

Re: [Qemu-devel] [PATCH 1/2] hw/sd: implement CMD23 (SET_BLOCK_COUNT) for MMC compatibility

2015-12-06 Thread Andrew Baumann
Hi Peter, > From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Sunday, 6 December 2015 15:47 > On Sun, Dec 6, 2015 at 1:20 PM, Andrew Baumann > wrote: > >> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > >> Sent: Saturday, 5 December

Re: [Qemu-devel] [PATCH 1/2] hw/sd: implement CMD23 (SET_BLOCK_COUNT) for MMC compatibility

2015-12-05 Thread Peter Crosthwaite
On Fri, Dec 4, 2015 at 1:16 PM, Andrew Baumann wrote: > CMD23 is optional for SD but required for MMC, and Tianocore EDK2 > (UEFI) uses it at boot. > > Signed-off-by: Andrew Baumann > --- > For EDK2 to boot all we actually need to do is

[Qemu-devel] [PATCH 1/2] hw/sd: implement CMD23 (SET_BLOCK_COUNT) for MMC compatibility

2015-12-04 Thread Andrew Baumann
CMD23 is optional for SD but required for MMC, and Tianocore EDK2 (UEFI) uses it at boot. Signed-off-by: Andrew Baumann --- For EDK2 to boot all we actually need to do is return success and ignore the command, but it seemed much safer to implement the full