Re: [Qemu-devel] [PATCH 1/2] iscsi: Use bs->sg for everything else than disks

2014-03-05 Thread Kevin Wolf
Am 05.03.2014 um 17:02 hat Peter Lieven geschrieben: > Am 05.03.2014 16:00, schrieb Kevin Wolf: > > The current iscsi block driver code makes the rather arbitrary decision > > that TYPE_MEDIUM_CHANGER and TYPE_TAPE devices have bs->sg = 1 and all > > other device types are disks. > > > > Instead of

Re: [Qemu-devel] [PATCH 1/2] iscsi: Use bs->sg for everything else than disks

2014-03-05 Thread Peter Lieven
Am 05.03.2014 16:00, schrieb Kevin Wolf: > The current iscsi block driver code makes the rather arbitrary decision > that TYPE_MEDIUM_CHANGER and TYPE_TAPE devices have bs->sg = 1 and all > other device types are disks. > > Instead of this, check for TYPE_DISK to expose the disk interface and > mak

Re: [Qemu-devel] [PATCH 1/2] iscsi: Use bs->sg for everything else than disks

2014-03-05 Thread Benoît Canet
The Wednesday 05 Mar 2014 à 16:41:20 (+0100), Kevin Wolf wrote : > Am 05.03.2014 um 16:33 hat Benoît Canet geschrieben: > > The Wednesday 05 Mar 2014 à 16:00:48 (+0100), Kevin Wolf wrote : > > > The current iscsi block driver code makes the rather arbitrary decision > > > that TYPE_MEDIUM_CHANGER a

Re: [Qemu-devel] [PATCH 1/2] iscsi: Use bs->sg for everything else than disks

2014-03-05 Thread Kevin Wolf
Am 05.03.2014 um 16:33 hat Benoît Canet geschrieben: > The Wednesday 05 Mar 2014 à 16:00:48 (+0100), Kevin Wolf wrote : > > The current iscsi block driver code makes the rather arbitrary decision > > that TYPE_MEDIUM_CHANGER and TYPE_TAPE devices have bs->sg = 1 and all > > other device types are d

Re: [Qemu-devel] [PATCH 1/2] iscsi: Use bs->sg for everything else than disks

2014-03-05 Thread Benoît Canet
The Wednesday 05 Mar 2014 à 16:00:48 (+0100), Kevin Wolf wrote : > The current iscsi block driver code makes the rather arbitrary decision > that TYPE_MEDIUM_CHANGER and TYPE_TAPE devices have bs->sg = 1 and all > other device types are disks. > > Instead of this, check for TYPE_DISK to expose the

[Qemu-devel] [PATCH 1/2] iscsi: Use bs->sg for everything else than disks

2014-03-05 Thread Kevin Wolf
The current iscsi block driver code makes the rather arbitrary decision that TYPE_MEDIUM_CHANGER and TYPE_TAPE devices have bs->sg = 1 and all other device types are disks. Instead of this, check for TYPE_DISK to expose the disk interface and make everything else bs->sg = 1. In particular, this in