Re: [Qemu-devel] [PATCH 1/2] libcacard: fix soft=... parsing in vcard_emul_options

2011-06-27 Thread Christophe Fergeau
On Fri, Jun 24, 2011 at 06:51:51PM +0200, Alon Levy wrote: On Fri, Jun 24, 2011 at 04:37:39PM +0200, Christophe Fergeau wrote: The previous parser had copy and paste errors when computing vname_length and type_params_length, name was used instead of respectively vname and type_params. This

[Qemu-devel] [PATCH 1/2] libcacard: fix soft=... parsing in vcard_emul_options

2011-06-24 Thread Christophe Fergeau
The previous parser had copy and paste errors when computing vname_length and type_params_length, name was used instead of respectively vname and type_params. This led to length that could be bigger than the input string, and to access out of the array bounds when trying to copy these strings.

Re: [Qemu-devel] [PATCH 1/2] libcacard: fix soft=... parsing in vcard_emul_options

2011-06-24 Thread Alon Levy
On Fri, Jun 24, 2011 at 04:37:39PM +0200, Christophe Fergeau wrote: The previous parser had copy and paste errors when computing vname_length and type_params_length, name was used instead of respectively vname and type_params. This led to length that could be bigger than the input string, and