Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Jason Wang
On 08/27/2015 09:10 PM, Greg Kurz wrote: > On Thu, 27 Aug 2015 15:30:55 +0300 > "Michael S. Tsirkin" wrote: > >> On Thu, Aug 27, 2015 at 01:27:54PM +0100, Peter Maydell wrote: >>> On 27 August 2015 at 13:25, Michael S. Tsirkin wrote: On Thu, Aug 27, 2015 at 01:20:52PM +0100, Peter Maydell

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Greg Kurz
On Thu, 27 Aug 2015 15:30:55 +0300 "Michael S. Tsirkin" wrote: > On Thu, Aug 27, 2015 at 01:27:54PM +0100, Peter Maydell wrote: > > On 27 August 2015 at 13:25, Michael S. Tsirkin wrote: > > > On Thu, Aug 27, 2015 at 01:20:52PM +0100, Peter Maydell wrote: > > >> On 27 August 2015 at 13:17, Michae

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Michael S. Tsirkin
On Thu, Aug 27, 2015 at 01:27:54PM +0100, Peter Maydell wrote: > On 27 August 2015 at 13:25, Michael S. Tsirkin wrote: > > On Thu, Aug 27, 2015 at 01:20:52PM +0100, Peter Maydell wrote: > >> On 27 August 2015 at 13:17, Michael S. Tsirkin wrote: > >> > Basically the point is that ABI is extended t

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Peter Maydell
On 27 August 2015 at 13:25, Michael S. Tsirkin wrote: > On Thu, Aug 27, 2015 at 01:20:52PM +0100, Peter Maydell wrote: >> On 27 August 2015 at 13:17, Michael S. Tsirkin wrote: >> > Basically the point is that ABI is extended to make >> > ioeventfd with len = 0 mean "any length". >> > 0 is thus no

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Michael S. Tsirkin
On Thu, Aug 27, 2015 at 01:20:52PM +0100, Peter Maydell wrote: > On 27 August 2015 at 13:17, Michael S. Tsirkin wrote: > > Basically the point is that ABI is extended to make > > ioeventfd with len = 0 mean "any length". > > 0 is thus not meaningless anymore. > > But how can you do adjustment for

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Peter Maydell
On 27 August 2015 at 13:17, Michael S. Tsirkin wrote: > Basically the point is that ABI is extended to make > ioeventfd with len = 0 mean "any length". > 0 is thus not meaningless anymore. But how can you do adjustment for incorrect endianness if you don't know the size of the data that you're tr

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Michael S. Tsirkin
On Thu, Aug 27, 2015 at 01:12:32PM +0100, Peter Maydell wrote: > On 27 August 2015 at 12:08, Michael S. Tsirkin wrote: > > On Thu, Aug 27, 2015 at 12:04:49PM +0100, Peter Maydell wrote: > >> On 27 August 2015 at 11:53, Michael S. Tsirkin wrote: > >> > On Thu, Aug 27, 2015 at 11:49:32AM +0100, Pet

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Peter Maydell
On 27 August 2015 at 12:08, Michael S. Tsirkin wrote: > On Thu, Aug 27, 2015 at 12:04:49PM +0100, Peter Maydell wrote: >> On 27 August 2015 at 11:53, Michael S. Tsirkin wrote: >> > On Thu, Aug 27, 2015 at 11:49:32AM +0100, Peter Maydell wrote: >> >> But *why* does it require the size to be zero?

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Michael S. Tsirkin
On Thu, Aug 27, 2015 at 12:04:49PM +0100, Peter Maydell wrote: > On 27 August 2015 at 11:53, Michael S. Tsirkin wrote: > > On Thu, Aug 27, 2015 at 11:49:32AM +0100, Peter Maydell wrote: > >> But *why* does it require the size to be zero? I still think > >> the caller should just avoid trying to do

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Peter Maydell
On 27 August 2015 at 11:53, Michael S. Tsirkin wrote: > On Thu, Aug 27, 2015 at 11:49:32AM +0100, Peter Maydell wrote: >> But *why* does it require the size to be zero? I still think >> the caller should just avoid trying to do zero-size memory >> operations: they don't make sense. What is a zero

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Michael S. Tsirkin
On Thu, Aug 27, 2015 at 11:49:32AM +0100, Peter Maydell wrote: > On 27 August 2015 at 05:50, Jason Wang wrote: > > On 08/26/2015 10:51 PM, Greg Kurz wrote: > >> On Wed, 26 Aug 2015 15:21:59 +0100 > >> Peter Maydell wrote: > >>> This seems to me like a bug in the caller. Why would anything > >>> t

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Peter Maydell
On 27 August 2015 at 05:50, Jason Wang wrote: > On 08/26/2015 10:51 PM, Greg Kurz wrote: >> On Wed, 26 Aug 2015 15:21:59 +0100 >> Peter Maydell wrote: >>> This seems to me like a bug in the caller. Why would anything >>> try to call into the memory subsystem to do a zero-size >>> transaction? >>

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-26 Thread Jason Wang
On 08/26/2015 10:51 PM, Greg Kurz wrote: > On Wed, 26 Aug 2015 15:21:59 +0100 > Peter Maydell wrote: > >> On 26 August 2015 at 11:04, Jason Wang wrote: >>> Wildcard mmio eventfd use zero size, but it will lead abort() since it >>> was illegal in adjust_endianness(). Fix this by allowing zero si

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-26 Thread Greg Kurz
On Wed, 26 Aug 2015 15:21:59 +0100 Peter Maydell wrote: > On 26 August 2015 at 11:04, Jason Wang wrote: > > Wildcard mmio eventfd use zero size, but it will lead abort() since it > > was illegal in adjust_endianness(). Fix this by allowing zero size. > > > > Cc: Greg Kurz > > Cc: Paolo Bonzini

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-26 Thread Peter Maydell
On 26 August 2015 at 11:04, Jason Wang wrote: > Wildcard mmio eventfd use zero size, but it will lead abort() since it > was illegal in adjust_endianness(). Fix this by allowing zero size. > > Cc: Greg Kurz > Cc: Paolo Bonzini > Signed-off-by: Jason Wang This seems to me like a bug in the call

[Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-26 Thread Jason Wang
Wildcard mmio eventfd use zero size, but it will lead abort() since it was illegal in adjust_endianness(). Fix this by allowing zero size. Cc: Greg Kurz Cc: Paolo Bonzini Signed-off-by: Jason Wang --- memory.c | 1 + 1 file changed, 1 insertion(+) diff --git a/memory.c b/memory.c index 4eb138