Re: [Qemu-devel] [PATCH 1/2] monitor: Add dump-stack command

2019-06-24 Thread Markus Armbruster
Suraj Jitindar Singh writes: > On Wed, 2019-05-01 at 15:35 +1000, Suraj Jitindar Singh wrote: >> Add a monitor command "dump-stack" to be used to dump the stack for >> the >> current cpu. > > To summarise the discussion which occured on this patch, > > - It looks like it's ok to duplicate this fu

Re: [Qemu-devel] [PATCH 1/2] monitor: Add dump-stack command

2019-06-20 Thread Suraj Jitindar Singh
On Wed, 2019-05-01 at 15:35 +1000, Suraj Jitindar Singh wrote: > Add a monitor command "dump-stack" to be used to dump the stack for > the > current cpu. To summarise the discussion which occured on this patch, - It looks like it's ok to duplicate this functionality as it provides an easier metho

Re: [Qemu-devel] [PATCH 1/2] monitor: Add dump-stack command

2019-05-08 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> Suraj Jitindar Singh writes: > >> > >> > Add a monitor command "dump-stack" to be used to dump the stack for the > >> > current cpu. > >> > >> I guess thi

Re: [Qemu-devel] [PATCH 1/2] monitor: Add dump-stack command

2019-05-08 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> Suraj Jitindar Singh writes: >> >> > Add a monitor command "dump-stack" to be used to dump the stack for the >> > current cpu. >> >> I guess this is just for debugging. Correct? >> >> Shouldn't this be "info

Re: [Qemu-devel] [PATCH 1/2] monitor: Add dump-stack command

2019-05-08 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Suraj Jitindar Singh writes: > > > Add a monitor command "dump-stack" to be used to dump the stack for the > > current cpu. > > I guess this is just for debugging. Correct? > > Shouldn't this be "info stack", to match "info registers" and "info

Re: [Qemu-devel] [PATCH 1/2] monitor: Add dump-stack command

2019-05-07 Thread Markus Armbruster
Suraj Jitindar Singh writes: > Add a monitor command "dump-stack" to be used to dump the stack for the > current cpu. I guess this is just for debugging. Correct? Shouldn't this be "info stack", to match "info registers" and "info cpustats"? > > Signed-off-by: Suraj Jitindar Singh > --- > h

Re: [Qemu-devel] [PATCH 1/2] monitor: Add dump-stack command

2019-05-01 Thread David Gibson
On Wed, May 01, 2019 at 03:35:21PM +1000, Suraj Jitindar Singh wrote: > Add a monitor command "dump-stack" to be used to dump the stack for the > current cpu. So, you can already get guest backtraces by using the gdbstub functionality. I can see some benefit in allowing this more easily through h

Re: [Qemu-devel] [PATCH 1/2] monitor: Add dump-stack command

2019-05-01 Thread Dr. David Alan Gilbert
* Suraj Jitindar Singh (sjitindarsi...@gmail.com) wrote: > Add a monitor command "dump-stack" to be used to dump the stack for the > current cpu. > > Signed-off-by: Suraj Jitindar Singh OK, and for a debug-only command that's OK for HMP. > --- > hmp-commands.hx | 13 + > hmp.h

[Qemu-devel] [PATCH 1/2] monitor: Add dump-stack command

2019-04-30 Thread Suraj Jitindar Singh
Add a monitor command "dump-stack" to be used to dump the stack for the current cpu. Signed-off-by: Suraj Jitindar Singh --- hmp-commands.hx | 13 + hmp.h | 1 + include/qom/cpu.h | 10 ++ monitor.c | 12 qom/cpu.c | 10 ++