Re: [Qemu-devel] [PATCH 1/2] pc: acpi: use correct RSDT length for checksum

2018-11-26 Thread Igor Mammedov
On Fri, 23 Nov 2018 11:10:01 -0500 "Michael S. Tsirkin" wrote: > On Thu, Nov 22, 2018 at 11:29:33AM +0100, Igor Mammedov wrote: > > AcpiRsdpDescriptor describes revision 2 RSDP table so using sizeof(*rsdp) > > for checksum calculation isn't correct since we are adding extra 16 bytes. > > But acpi

Re: [Qemu-devel] [PATCH 1/2] pc: acpi: use correct RSDT length for checksum

2018-11-23 Thread Michael S. Tsirkin
On Thu, Nov 22, 2018 at 11:29:33AM +0100, Igor Mammedov wrote: > AcpiRsdpDescriptor describes revision 2 RSDP table so using sizeof(*rsdp) > for checksum calculation isn't correct since we are adding extra 16 bytes. > But acpi_data_push() zeroes out table, so just by luck we are summing up > exta z

[Qemu-devel] [PATCH 1/2] pc: acpi: use correct RSDT length for checksum

2018-11-22 Thread Igor Mammedov
AcpiRsdpDescriptor describes revision 2 RSDP table so using sizeof(*rsdp) for checksum calculation isn't correct since we are adding extra 16 bytes. But acpi_data_push() zeroes out table, so just by luck we are summing up exta zeros which still yelds correct checksum. Fix it up by explicitly stati