Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature

2014-09-23 Thread zhanghailiang
On 2014/9/23 19:12, Igor Mammedov wrote: On Tue, 23 Sep 2014 18:11:35 +0800 zhanghailiang wrote: On 2014/9/23 16:58, Tang Chen wrote: On 09/23/2014 04:40 PM, Igor Mammedov wrote: .. It's fine to use SRAT for these purposes on baremetal NUMA systems since due to used chipset constrains i

Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature

2014-09-23 Thread Igor Mammedov
On Tue, 23 Sep 2014 18:11:35 +0800 zhanghailiang wrote: > On 2014/9/23 16:58, Tang Chen wrote: > > > > On 09/23/2014 04:40 PM, Igor Mammedov wrote: > >> .. > >> It's fine to use SRAT for these purposes on baremetal NUMA systems since > >> due to used chipset constrains it's possible staticall

Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature

2014-09-23 Thread Igor Mammedov
On Tue, 23 Sep 2014 18:07:16 +0800 zhanghailiang wrote: > On 2014/9/23 17:01, Igor Mammedov wrote: > > On Mon, 22 Sep 2014 14:17:28 +0300 > > "Michael S. Tsirkin" wrote: > > > >> On Fri, Sep 19, 2014 at 02:37:46PM +0200, Igor Mammedov wrote: > >>> On Tue, 16 Sep 2014 18:39:15 +0800 > >>> zhangha

Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature

2014-09-23 Thread Tang Chen
On 09/23/2014 06:11 PM, zhanghailiang wrote: On 2014/9/23 16:58, Tang Chen wrote: On 09/23/2014 04:40 PM, Igor Mammedov wrote: .. It's fine to use SRAT for these purposes on baremetal NUMA systems since due to used chipset constrains it's possible statically allocate ranges for every po

Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature

2014-09-23 Thread zhanghailiang
On 2014/9/23 16:58, Tang Chen wrote: On 09/23/2014 04:40 PM, Igor Mammedov wrote: .. It's fine to use SRAT for these purposes on baremetal NUMA systems since due to used chipset constrains it's possible statically allocate ranges for every possible DIMM socket. However SRAT(which is optiona

Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature

2014-09-23 Thread zhanghailiang
On 2014/9/23 17:01, Igor Mammedov wrote: On Mon, 22 Sep 2014 14:17:28 +0300 "Michael S. Tsirkin" wrote: On Fri, Sep 19, 2014 at 02:37:46PM +0200, Igor Mammedov wrote: On Tue, 16 Sep 2014 18:39:15 +0800 zhanghailiang wrote: If we do not configure numa option, memory hotplug should work as w

Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature

2014-09-23 Thread Igor Mammedov
On Mon, 22 Sep 2014 14:17:28 +0300 "Michael S. Tsirkin" wrote: > On Fri, Sep 19, 2014 at 02:37:46PM +0200, Igor Mammedov wrote: > > On Tue, 16 Sep 2014 18:39:15 +0800 > > zhanghailiang wrote: > > > > > If we do not configure numa option, memory hotplug should work as well. > > > It should not d

Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature

2014-09-23 Thread Tang Chen
On 09/23/2014 04:40 PM, Igor Mammedov wrote: .. It's fine to use SRAT for these purposes on baremetal NUMA systems since due to used chipset constrains it's possible statically allocate ranges for every possible DIMM socket. However SRAT(which is optional table BTW) entries are not mandatory

Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature

2014-09-23 Thread Igor Mammedov
On Mon, 22 Sep 2014 17:03:12 +0800 Tang Chen wrote: > Hi Igor, > > On 09/19/2014 08:26 PM, Igor Mammedov wrote: > > On Wed, 17 Sep 2014 16:32:20 +0800 > > Hu Tao wrote: > > > >> On Tue, Sep 16, 2014 at 06:39:15PM +0800, zhanghailiang wrote: > >>> If we do not configure numa option, memory hotpl

Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature

2014-09-22 Thread Michael S. Tsirkin
On Fri, Sep 19, 2014 at 02:37:46PM +0200, Igor Mammedov wrote: > On Tue, 16 Sep 2014 18:39:15 +0800 > zhanghailiang wrote: > > > If we do not configure numa option, memory hotplug should work as well. > > It should not depend on numa option. > > > > Steps to reproduce: > > (1) Start VM: qemu-kvm

Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature

2014-09-22 Thread zhanghailiang
On 2014/9/22 17:03, Tang Chen wrote: Hi Igor, On 09/19/2014 08:26 PM, Igor Mammedov wrote: On Wed, 17 Sep 2014 16:32:20 +0800 Hu Tao wrote: On Tue, Sep 16, 2014 at 06:39:15PM +0800, zhanghailiang wrote: If we do not configure numa option, memory hotplug should work as well. It should not de

Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature

2014-09-22 Thread Tang Chen
Hi Igor, On 09/19/2014 08:26 PM, Igor Mammedov wrote: On Wed, 17 Sep 2014 16:32:20 +0800 Hu Tao wrote: On Tue, Sep 16, 2014 at 06:39:15PM +0800, zhanghailiang wrote: If we do not configure numa option, memory hotplug should work as well. It should not depend on numa option. Steps to reprodu

Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature

2014-09-19 Thread Igor Mammedov
On Tue, 16 Sep 2014 18:39:15 +0800 zhanghailiang wrote: > If we do not configure numa option, memory hotplug should work as well. > It should not depend on numa option. > > Steps to reproduce: > (1) Start VM: qemu-kvm -m 1024,slots=4,maxmem=8G > (2) Hotplug memory > It will fail and reports: > "

Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature

2014-09-19 Thread Igor Mammedov
On Wed, 17 Sep 2014 16:32:20 +0800 Hu Tao wrote: > On Tue, Sep 16, 2014 at 06:39:15PM +0800, zhanghailiang wrote: > > If we do not configure numa option, memory hotplug should work as well. > > It should not depend on numa option. > > > > Steps to reproduce: > > (1) Start VM: qemu-kvm -m 1024,sl

Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature

2014-09-17 Thread Hu Tao
On Wed, Sep 17, 2014 at 02:19:05PM +0400, Andrey Korolyov wrote: > On Wed, Sep 17, 2014 at 2:00 PM, Tang Chen wrote: > > Add Andrey Korolyov > > > > On 09/17/2014 04:32 PM, Hu Tao wrote: > >> > >> On Tue, Sep 16, 2014 at 06:39:15PM +0800, zhanghailiang wrote: > >>> > >>> If we do not configure nu

Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature

2014-09-17 Thread Andrey Korolyov
On Wed, Sep 17, 2014 at 2:00 PM, Tang Chen wrote: > Add Andrey Korolyov > > On 09/17/2014 04:32 PM, Hu Tao wrote: >> >> On Tue, Sep 16, 2014 at 06:39:15PM +0800, zhanghailiang wrote: >>> >>> If we do not configure numa option, memory hotplug should work as well. >>> It should not depend on numa o

Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature

2014-09-17 Thread Tang Chen
Add Andrey Korolyov On 09/17/2014 04:32 PM, Hu Tao wrote: On Tue, Sep 16, 2014 at 06:39:15PM +0800, zhanghailiang wrote: If we do not configure numa option, memory hotplug should work as well. It should not depend on numa option. Steps to reproduce: (1) Start VM: qemu-kvm -m 1024,slots=4,maxm

Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature

2014-09-17 Thread zhanghailiang
On 2014/9/17 16:32, Hu Tao wrote: On Tue, Sep 16, 2014 at 06:39:15PM +0800, zhanghailiang wrote: If we do not configure numa option, memory hotplug should work as well. It should not depend on numa option. Steps to reproduce: (1) Start VM: qemu-kvm -m 1024,slots=4,maxmem=8G (2) Hotplug memory I

Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature

2014-09-17 Thread Hu Tao
On Tue, Sep 16, 2014 at 06:39:15PM +0800, zhanghailiang wrote: > If we do not configure numa option, memory hotplug should work as well. > It should not depend on numa option. > > Steps to reproduce: > (1) Start VM: qemu-kvm -m 1024,slots=4,maxmem=8G > (2) Hotplug memory > It will fail and reports

[Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature

2014-09-16 Thread zhanghailiang
If we do not configure numa option, memory hotplug should work as well. It should not depend on numa option. Steps to reproduce: (1) Start VM: qemu-kvm -m 1024,slots=4,maxmem=8G (2) Hotplug memory It will fail and reports: "'DIMM property node has value 0' which exceeds the number of numa nodes: 0