Re: [Qemu-devel] [PATCH 1/2] qemu-char: Fix reconnect socket error reporting

2014-10-08 Thread Markus Armbruster
miny...@acm.org writes: From: Corey Minyard cminy...@mvista.com If reconnect was set, errors wouldn't always be reported. Fix that and also only report a connect error once until a connection has been made. The primary purpose of this is to tell the user that a connection failed so they

[Qemu-devel] [PATCH 1/2] qemu-char: Fix reconnect socket error reporting

2014-10-06 Thread minyard
From: Corey Minyard cminy...@mvista.com If reconnect was set, errors wouldn't always be reported. Fix that and also only report a connect error once until a connection has been made. The primary purpose of this is to tell the user that a connection failed so they can know they need to figure out

Re: [Qemu-devel] [PATCH 1/2] qemu-char: Fix reconnect socket error reporting

2014-10-06 Thread Eric Blake
On 10/06/2014 11:59 AM, miny...@acm.org wrote: From: Corey Minyard cminy...@mvista.com If reconnect was set, errors wouldn't always be reported. Fix that and also only report a connect error once until a connection has been made. The primary purpose of this is to tell the user that a

Re: [Qemu-devel] [PATCH 1/2] qemu-char: Fix reconnect socket error reporting

2014-10-06 Thread Corey Minyard
On 10/06/2014 01:36 PM, Eric Blake wrote: On 10/06/2014 11:59 AM, miny...@acm.org wrote: From: Corey Minyard cminy...@mvista.com If reconnect was set, errors wouldn't always be reported. Fix that and also only report a connect error once until a connection has been made. The primary

Re: [Qemu-devel] [PATCH 1/2] qemu-char: Fix reconnect socket error reporting

2014-10-06 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 06/10/2014 20:36, Eric Blake ha scritto: -qemu_chr_socket_restart_timer(chr); + check_report_connect_error(chr, Unable to connect to); Works in English, but if there is ever translation of the message printed in