Re: [Qemu-devel] [PATCH 1/2] qemu-error: Introduce get_errno_name()

2010-05-10 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: On 05/03/2010 08:06 AM, Markus Armbruster wrote: Luiz Capitulinolcapitul...@redhat.com writes: We need to expose errno in QMP, for three reasons: 1. Some error handling functions print errno codes to the user, while it's

Re: [Qemu-devel] [PATCH 1/2] qemu-error: Introduce get_errno_name()

2010-05-10 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Tue, 04 May 2010 16:56:19 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 05/04/2010 03:30 PM, Luiz Capitulino wrote: StateVmSaveFailed is not like CommandFailed, there are five errors in do_savevm() and StateVmSaveFailed happens

Re: [Qemu-devel] [PATCH 1/2] qemu-error: Introduce get_errno_name()

2010-05-05 Thread Luiz Capitulino
On Tue, 04 May 2010 09:03:47 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 05/04/2010 08:56 AM, Luiz Capitulino wrote: On Mon, 03 May 2010 08:16:35 -0500 Anthony Liguorianth...@codemonkey.ws wrote: On 05/03/2010 08:06 AM, Markus Armbruster wrote: Luiz

Re: [Qemu-devel] [PATCH 1/2] qemu-error: Introduce get_errno_name()

2010-05-05 Thread Anthony Liguori
On 05/04/2010 03:30 PM, Luiz Capitulino wrote: StateVmSaveFailed is not like CommandFailed, there are five errors in do_savevm() and StateVmSaveFailed happens to be one of them. But I understand what you mean and I have considered doing something like it, one of the problems though is that

Re: [Qemu-devel] [PATCH 1/2] qemu-error: Introduce get_errno_name()

2010-05-05 Thread Luiz Capitulino
On Tue, 04 May 2010 16:56:19 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 05/04/2010 03:30 PM, Luiz Capitulino wrote: StateVmSaveFailed is not like CommandFailed, there are five errors in do_savevm() and StateVmSaveFailed happens to be one of them. But I understand what

Re: [Qemu-devel] [PATCH 1/2] qemu-error: Introduce get_errno_name()

2010-05-04 Thread Anthony Liguori
On 05/04/2010 08:56 AM, Luiz Capitulino wrote: On Mon, 03 May 2010 08:16:35 -0500 Anthony Liguorianth...@codemonkey.ws wrote: On 05/03/2010 08:06 AM, Markus Armbruster wrote: Luiz Capitulinolcapitul...@redhat.com writes: We need to expose errno in QMP, for three

Re: [Qemu-devel] [PATCH 1/2] qemu-error: Introduce get_errno_name()

2010-05-04 Thread Luiz Capitulino
On Mon, 03 May 2010 08:16:35 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 05/03/2010 08:06 AM, Markus Armbruster wrote: Luiz Capitulinolcapitul...@redhat.com writes: We need to expose errno in QMP, for three reasons: 1. Some error handling functions print errno codes

Re: [Qemu-devel] [PATCH 1/2] qemu-error: Introduce get_errno_name()

2010-05-03 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: We need to expose errno in QMP, for three reasons: 1. Some error handling functions print errno codes to the user, while it's debatable whether this is good or not from a user perspective, sometimes it's the best we can do because

Re: [Qemu-devel] [PATCH 1/2] qemu-error: Introduce get_errno_name()

2010-05-03 Thread Anthony Liguori
On 05/03/2010 08:06 AM, Markus Armbruster wrote: Luiz Capitulinolcapitul...@redhat.com writes: We need to expose errno in QMP, for three reasons: 1. Some error handling functions print errno codes to the user, while it's debatable whether this is good or not from a user

[Qemu-devel] [PATCH 1/2] qemu-error: Introduce get_errno_name()

2010-04-28 Thread Luiz Capitulino
We need to expose errno in QMP, for three reasons: 1. Some error handling functions print errno codes to the user, while it's debatable whether this is good or not from a user perspective, sometimes it's the best we can do because it's what system calls and libraries return 2.