Re: [Qemu-devel] [PATCH 1/2] qemu-ga: guest-suspend: make the API synchronous

2012-05-14 Thread Eric Blake
On 05/14/2012 08:56 AM, Michael Roth wrote: > From: Luiz Capitulino > > Currently, qemu-ga has a SIGCHLD handler that automatically reaps terminated > children processes. The idea is to avoid having qemu-ga commands blocked > waiting for children to terminate. > > This commit does just that. Th

[Qemu-devel] [PATCH 1/2] qemu-ga: guest-suspend: make the API synchronous

2012-05-14 Thread Michael Roth
From: Luiz Capitulino Currently, qemu-ga has a SIGCHLD handler that automatically reaps terminated children processes. The idea is to avoid having qemu-ga commands blocked waiting for children to terminate. That approach has two problems: 1. qemu-ga is unable to detect errors in the child, mea

Re: [Qemu-devel] [PATCH 1/2] qemu-ga: guest-suspend: make the API synchronous

2012-05-11 Thread Eric Blake
On 05/11/2012 01:19 PM, Luiz Capitulino wrote: > Currently, qemu-ga has a SIGCHLD handler that automatically reaps terminated > children processes. The idea is to avoid having qemu-ga commands blocked > waiting for children to terminate. > > + > +rpid = waitpid(pid, &status, 0); You need to

[Qemu-devel] [PATCH 1/2] qemu-ga: guest-suspend: make the API synchronous

2012-05-11 Thread Luiz Capitulino
Currently, qemu-ga has a SIGCHLD handler that automatically reaps terminated children processes. The idea is to avoid having qemu-ga commands blocked waiting for children to terminate. That approach has two problems: 1. qemu-ga is unable to detect errors in the child, meaning that qemu-ga re