Re: [Qemu-devel] [PATCH 1/2] qemu-timer: Call clock reset notifiers on forward jumps

2015-06-18 Thread Paolo Bonzini
On 18/06/2015 14:58, Paul Donohue wrote: > On Wed, Jun 17, 2015 at 04:00:06PM +0200, Paolo Bonzini wrote: >> On 12/06/2015 16:08, Paul Donohue wrote: >>> +static inline int64_t get_max_clock_jump(void) >>> +{ >>> +// This should be small enough to prevent excessive interrupts from >>> being

Re: [Qemu-devel] [PATCH 1/2] qemu-timer: Call clock reset notifiers on forward jumps

2015-06-18 Thread Paul Donohue
On Wed, Jun 17, 2015 at 04:00:06PM +0200, Paolo Bonzini wrote: > On 12/06/2015 16:08, Paul Donohue wrote: > > +static inline int64_t get_max_clock_jump(void) > > +{ > > +// This should be small enough to prevent excessive interrupts from > > being > > +// generated by the RTC on clock jump

Re: [Qemu-devel] [PATCH 1/2] qemu-timer: Call clock reset notifiers on forward jumps

2015-06-17 Thread Paolo Bonzini
On 12/06/2015 16:08, Paul Donohue wrote: > +static inline int64_t get_max_clock_jump(void) > +{ > +// This should be small enough to prevent excessive interrupts from being > +// generated by the RTC on clock jumps, but large enough to avoid > frequent > +// unnecessary resets in idl

[Qemu-devel] [PATCH 1/2] qemu-timer: Call clock reset notifiers on forward jumps

2015-06-12 Thread Paul Donohue
Commit 691a0c9c introduced a mechanism by which QEMU_CLOCK_HOST can notify other parts of the emulator when the host clock has jumped backward. This is used to avoid stalling timers that were scheduled based on the host clock. However, if the host clock jumps forward, then timers that were sched