Re: [Qemu-devel] [PATCH 1/2] script/clean-includes: added duplicate #include check

2016-10-20 Thread Eric Blake
On 10/20/2016 04:52 AM, Anand J wrote: > Added script to check duplicate #include entries. This check will scan > and print the files in which duplicate #include entries are present. Subject line typo: s,script/,scripts/, > > Script might output false positive entries as well. Such entries

Re: [Qemu-devel] [PATCH 1/2] script/clean-includes: added duplicate #include check

2016-10-20 Thread Eric Blake
[meta-comment] On 10/20/2016 04:52 AM, Anand J wrote: > Added script to check duplicate #include entries. This check will scan > and print the files in which duplicate #include entries are present. This appears to be a v2 patch. But it is missing a 0/2 cover letter, and mention of v2 in the

Re: [Qemu-devel] [PATCH 1/2] script/clean-includes: added duplicate #include check

2016-10-20 Thread Anand J
send a new patch. please check http://patchwork.ozlabs.org/patch/684533/ Thanks, Anand On Thu, Oct 20, 2016 at 2:38 PM, Thomas Huth wrote: > On 18.10.2016 14:38, Anand J wrote: > > > > > > On Tue, Oct 18, 2016 at 4:03 PM, Anand J >

[Qemu-devel] [PATCH 1/2] script/clean-includes: added duplicate #include check

2016-10-20 Thread Anand J
Added script to check duplicate #include entries. This check will scan and print the files in which duplicate #include entries are present. Script might output false positive entries as well. Such entries should not be removed. So if it finds any duplicate entries script will terminate with an

Re: [Qemu-devel] [PATCH 1/2] script/clean-includes: added duplicate #include check

2016-10-20 Thread Thomas Huth
On 18.10.2016 14:38, Anand J wrote: > > > On Tue, Oct 18, 2016 at 4:03 PM, Anand J > wrote: > > Added script to check duplicate #include entries. This check will scan > and print the files in which duplicate #include entries

Re: [Qemu-devel] [PATCH 1/2] script/clean-includes: added duplicate #include check

2016-10-18 Thread Anand J
On Tue, Oct 18, 2016 at 4:03 PM, Anand J wrote: > Added script to check duplicate #include entries. This check will scan > and print the files in which duplicate #include entries are present. > > Script might output false positive entries as well. Such entries should >

[Qemu-devel] [PATCH 1/2] script/clean-includes: added duplicate #include check

2016-10-18 Thread Anand J
Added script to check duplicate #include entries. This check will scan and print the files in which duplicate #include entries are present. Script might output false positive entries as well. Such entries should not be removed. So if it finds any duplicate entries script will terminate with an