Re: [Qemu-devel] [PATCH 1/2] scsi: Optimize scsi_req_alloc

2014-09-11 Thread Paolo Bonzini
Just a few nits... Il 11/09/2014 12:16, Fam Zheng ha scritto: > +uint32_t sense_len; sense_len is initialized to zero, might as well do that via memset. > +uint8_t sense[SCSI_SENSE_BUF_SIZE]; > +bool enqueued; > +bool io_canceled; > +

[Qemu-devel] [PATCH 1/2] scsi: Optimize scsi_req_alloc

2014-09-11 Thread Fam Zheng
Zeroing sense buffer for each scsi request is not efficient, we can just leave it uninitialized because sense_len is set to 0. Move the implicitly zeroes fields to the end of the structure and use a partial memset. Also change g_malloc0 to g_slice_alloc. Signed-off-by: Fam Zheng --- hw/scsi/sc