On 2012-02-15 09:30, Jan Kiszka wrote:
> On 2012-02-15 09:12, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> Signed-off-by: Zhi Yong Wu
>> ---
>> slirp/if.c |2 --
>> 1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/slirp/if.c b/slirp/if.c
>> index 2852396..8e0cac2
On 15 February 2012 23:02, Andreas Färber wrote:
> Am 15.02.2012 10:38, schrieb Michael S. Tsirkin:
>> why does slirp have all these
>> defines in the first place?
>>
>> slirp/mbuf.h:#define m_nextpkt m_hdr.mh_nextpkt
>> slirp/mbuf.h:#define ifs_next m_nextpkt
>>
>> Seriously, #define for a field
Am 15.02.2012 10:38, schrieb Michael S. Tsirkin:
> why does slirp have all these
> defines in the first place?
>
> slirp/mbuf.h:#define m_nextpkt m_hdr.mh_nextpkt
> slirp/mbuf.h:#define ifs_next m_nextpkt
>
> Seriously, #define for a field name?
We have some such #defines in ibm8514 graphics ca
On 2012-02-15 10:38, Michael S. Tsirkin wrote:
> On Wed, Feb 15, 2012 at 09:30:23AM +0100, Jan Kiszka wrote:
>> On 2012-02-15 09:12, zwu.ker...@gmail.com wrote:
>>> From: Zhi Yong Wu
>>>
>>> Signed-off-by: Zhi Yong Wu
>>> ---
>>> slirp/if.c |2 --
>>> 1 files changed, 0 insertions(+), 2 dele
On Wed, Feb 15, 2012 at 09:30:23AM +0100, Jan Kiszka wrote:
> On 2012-02-15 09:12, zwu.ker...@gmail.com wrote:
> > From: Zhi Yong Wu
> >
> > Signed-off-by: Zhi Yong Wu
> > ---
> > slirp/if.c |2 --
> > 1 files changed, 0 insertions(+), 2 deletions(-)
> >
> > diff --git a/slirp/if.c b/slirp
On 2012-02-15 09:12, zwu.ker...@gmail.com wrote:
> From: Zhi Yong Wu
>
> Signed-off-by: Zhi Yong Wu
> ---
> slirp/if.c |2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/slirp/if.c b/slirp/if.c
> index 2852396..8e0cac2 100644
> --- a/slirp/if.c
> +++ b/slirp/if.c
>
From: Zhi Yong Wu
Signed-off-by: Zhi Yong Wu
---
slirp/if.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/slirp/if.c b/slirp/if.c
index 2852396..8e0cac2 100644
--- a/slirp/if.c
+++ b/slirp/if.c
@@ -8,8 +8,6 @@
#include
#include "qemu-timer.h"
-#define ifs_init(i
