Re: [Qemu-devel] [PATCH 1/2] tests/libqtest: Fix possible deadlock in qtest initialization

2014-03-12 Thread Markus Armbruster
Marcel Apfelbaum marce...@redhat.com writes: 'socket_accept' waits for Qemu to init its unix socket. If Qemu encounters an error during command line parsing, it can exit before initializing the communication channel. It gets worse as the make check-qtest-* gets stuck without notifying which

Re: [Qemu-devel] [PATCH 1/2] tests/libqtest: Fix possible deadlock in qtest initialization

2014-03-12 Thread Marcel Apfelbaum
On Wed, 2014-03-12 at 10:42 +0100, Markus Armbruster wrote: Marcel Apfelbaum marce...@redhat.com writes: 'socket_accept' waits for Qemu to init its unix socket. If Qemu encounters an error during command line parsing, it can exit before initializing the communication channel. It gets

[Qemu-devel] [PATCH 1/2] tests/libqtest: Fix possible deadlock in qtest initialization

2014-03-10 Thread Marcel Apfelbaum
'socket_accept' waits for Qemu to init its unix socket. If Qemu encounters an error during command line parsing, it can exit before initializing the communication channel. It gets worse as the make check-qtest-* gets stuck without notifying which test exactly has problems, so debugging can be a

Re: [Qemu-devel] [PATCH 1/2] tests/libqtest: Fix possible deadlock in qtest initialization

2014-03-10 Thread Stefan Hajnoczi
On Mon, Mar 10, 2014 at 02:12:13PM +0200, Marcel Apfelbaum wrote: @@ -123,6 +125,11 @@ QTestState *qtest_init(const char *extra_args) sock = init_socket(socket_path); qmpsock = init_socket(qmp_socket_path); +setsockopt(sock, SOL_SOCKET, SO_RCVTIMEO, (void *)socket_timeout, +