Re: [Qemu-devel] [PATCH 1/2] tests: Expose regression in QemuOpts visitor

2017-03-21 Thread Laurent Vivier
On 21/03/2017 17:01, Markus Armbruster wrote: > Eric Blake writes: > >> On 03/21/2017 08:33 AM, Laurent Vivier wrote: >>> On 21/03/2017 14:21, Eric Blake wrote: On 03/21/2017 04:01 AM, Laurent Vivier wrote: > On 21/03/2017 04:17, Eric Blake wrote: >> Commit 15c2f669e broke the abilit

Re: [Qemu-devel] [PATCH 1/2] tests: Expose regression in QemuOpts visitor

2017-03-21 Thread Markus Armbruster
Eric Blake writes: > On 03/21/2017 08:33 AM, Laurent Vivier wrote: >> On 21/03/2017 14:21, Eric Blake wrote: >>> On 03/21/2017 04:01 AM, Laurent Vivier wrote: On 21/03/2017 04:17, Eric Blake wrote: > Commit 15c2f669e broke the ability of the QemuOpts visitor to > flag extra input par

Re: [Qemu-devel] [PATCH 1/2] tests: Expose regression in QemuOpts visitor

2017-03-21 Thread Eric Blake
On 03/21/2017 08:33 AM, Laurent Vivier wrote: > On 21/03/2017 14:21, Eric Blake wrote: >> On 03/21/2017 04:01 AM, Laurent Vivier wrote: >>> On 21/03/2017 04:17, Eric Blake wrote: Commit 15c2f669e broke the ability of the QemuOpts visitor to flag extra input parameters, but the regression

Re: [Qemu-devel] [PATCH 1/2] tests: Expose regression in QemuOpts visitor

2017-03-21 Thread Laurent Vivier
On 21/03/2017 14:21, Eric Blake wrote: > On 03/21/2017 04:01 AM, Laurent Vivier wrote: >> On 21/03/2017 04:17, Eric Blake wrote: >>> Commit 15c2f669e broke the ability of the QemuOpts visitor to >>> flag extra input parameters, but the regression went unnoticed >>> because of missing testsuite cove

Re: [Qemu-devel] [PATCH 1/2] tests: Expose regression in QemuOpts visitor

2017-03-21 Thread Eric Blake
On 03/21/2017 04:01 AM, Laurent Vivier wrote: > On 21/03/2017 04:17, Eric Blake wrote: >> Commit 15c2f669e broke the ability of the QemuOpts visitor to >> flag extra input parameters, but the regression went unnoticed >> because of missing testsuite coverage. Add a test to cover this. > > I don't

Re: [Qemu-devel] [PATCH 1/2] tests: Expose regression in QemuOpts visitor

2017-03-21 Thread Laurent Vivier
On 21/03/2017 04:17, Eric Blake wrote: > Commit 15c2f669e broke the ability of the QemuOpts visitor to > flag extra input parameters, but the regression went unnoticed > because of missing testsuite coverage. Add a test to cover this. I don't know where I'm wrong, but when I run this test without

Re: [Qemu-devel] [PATCH 1/2] tests: Expose regression in QemuOpts visitor

2017-03-20 Thread Michael Roth
Quoting Eric Blake (2017-03-20 22:17:04) > Commit 15c2f669e broke the ability of the QemuOpts visitor to > flag extra input parameters, but the regression went unnoticed > because of missing testsuite coverage. Add a test to cover this. > > Signed-off-by: Eric Blake Reviewed-by: Michael Roth

[Qemu-devel] [PATCH 1/2] tests: Expose regression in QemuOpts visitor

2017-03-20 Thread Eric Blake
Commit 15c2f669e broke the ability of the QemuOpts visitor to flag extra input parameters, but the regression went unnoticed because of missing testsuite coverage. Add a test to cover this. Signed-off-by: Eric Blake --- tests/test-opts-visitor.c | 20 1 file changed, 20 ins