Re: [Qemu-devel] [PATCH 1/2] vfio-pci: Introduce vfio_register_event_notifier helper

2019-01-18 Thread Cornelia Huck
On Fri, 18 Jan 2019 10:08:12 +0100 Auger Eric wrote: > Hi Alexey, > > On 1/18/19 5:14 AM, Alexey Kardashevskiy wrote: > > > > > > On 17/01/2019 20:16, Auger Eric wrote: > >> Hi Alexey, Cornelia, > >> > >> On 1/17/19 4:46 AM, Alexey Kardashevskiy wrote: > >>> > >>> > >>> On 12/01/2019 03:58

Re: [Qemu-devel] [PATCH 1/2] vfio-pci: Introduce vfio_register_event_notifier helper

2019-01-18 Thread Auger Eric
Hi Alexey, On 1/18/19 5:14 AM, Alexey Kardashevskiy wrote: > > > On 17/01/2019 20:16, Auger Eric wrote: >> Hi Alexey, Cornelia, >> >> On 1/17/19 4:46 AM, Alexey Kardashevskiy wrote: >>> >>> >>> On 12/01/2019 03:58, Eric Auger wrote: The code used to attach the eventfd handler for the ERR an

Re: [Qemu-devel] [PATCH 1/2] vfio-pci: Introduce vfio_register_event_notifier helper

2019-01-17 Thread Alexey Kardashevskiy
On 17/01/2019 20:16, Auger Eric wrote: > Hi Alexey, Cornelia, > > On 1/17/19 4:46 AM, Alexey Kardashevskiy wrote: >> >> >> On 12/01/2019 03:58, Eric Auger wrote: >>> The code used to attach the eventfd handler for the ERR and >>> REQ irq indices can be factorized into a helper. In subsequent >>

Re: [Qemu-devel] [PATCH 1/2] vfio-pci: Introduce vfio_register_event_notifier helper

2019-01-17 Thread Auger Eric
Hi Alexey, Cornelia, On 1/17/19 4:46 AM, Alexey Kardashevskiy wrote: > > > On 12/01/2019 03:58, Eric Auger wrote: >> The code used to attach the eventfd handler for the ERR and >> REQ irq indices can be factorized into a helper. In subsequent >> patches we will extend this helper to support othe

Re: [Qemu-devel] [PATCH 1/2] vfio-pci: Introduce vfio_register_event_notifier helper

2019-01-17 Thread Cornelia Huck
On Thu, 17 Jan 2019 14:46:42 +1100 Alexey Kardashevskiy wrote: > On 12/01/2019 03:58, Eric Auger wrote: > > The code used to attach the eventfd handler for the ERR and > > REQ irq indices can be factorized into a helper. In subsequent > > patches we will extend this helper to support other irq in

Re: [Qemu-devel] [PATCH 1/2] vfio-pci: Introduce vfio_register_event_notifier helper

2019-01-16 Thread Alexey Kardashevskiy
On 12/01/2019 03:58, Eric Auger wrote: > The code used to attach the eventfd handler for the ERR and > REQ irq indices can be factorized into a helper. In subsequent > patches we will extend this helper to support other irq indices. > > We test the notification is allowed outside of the helper:

Re: [Qemu-devel] [PATCH 1/2] vfio-pci: Introduce vfio_register_event_notifier helper

2019-01-15 Thread Auger Eric
Hi Cornelia, On 1/15/19 1:03 PM, Cornelia Huck wrote: > On Fri, 11 Jan 2019 17:58:00 +0100 > Eric Auger wrote: > >> The code used to attach the eventfd handler for the ERR and >> REQ irq indices can be factorized into a helper. In subsequent >> patches we will extend this helper to support other

Re: [Qemu-devel] [PATCH 1/2] vfio-pci: Introduce vfio_register_event_notifier helper

2019-01-15 Thread Cornelia Huck
On Fri, 11 Jan 2019 17:58:00 +0100 Eric Auger wrote: > The code used to attach the eventfd handler for the ERR and > REQ irq indices can be factorized into a helper. In subsequent > patches we will extend this helper to support other irq indices. Looks like a nice refactoring to me. > > We tes

[Qemu-devel] [PATCH 1/2] vfio-pci: Introduce vfio_register_event_notifier helper

2019-01-11 Thread Eric Auger
The code used to attach the eventfd handler for the ERR and REQ irq indices can be factorized into a helper. In subsequent patches we will extend this helper to support other irq indices. We test the notification is allowed outside of the helper: respectively check vdev->pci_aer and VFIO_FEATURE_E