Re: [Qemu-devel] [PATCH 1/2] virtio: Add backend feature testing functionnality

2016-09-09 Thread Marcel Apfelbaum
On 09/09/2016 02:36 PM, Maxime Coquelin wrote: On 09/09/2016 01:20 PM, Cornelia Huck wrote: On Fri, 9 Sep 2016 14:02:17 +0300 Marcel Apfelbaum wrote: I was thinking to keep the same function proposed by Maxime and change it to negate things: /* * A missing feature before all negotiation

Re: [Qemu-devel] [PATCH 1/2] virtio: Add backend feature testing functionnality

2016-09-09 Thread Maxime Coquelin
On 09/09/2016 01:20 PM, Cornelia Huck wrote: On Fri, 9 Sep 2016 14:02:17 +0300 Marcel Apfelbaum wrote: I was thinking to keep the same function proposed by Maxime and change it to negate things: /* * A missing feature before all negotiations finished will still be missing at the end.

Re: [Qemu-devel] [PATCH 1/2] virtio: Add backend feature testing functionnality

2016-09-09 Thread Cornelia Huck
On Fri, 9 Sep 2016 14:02:17 +0300 Marcel Apfelbaum wrote: > I was thinking to keep the same function proposed by Maxime and change it to > negate things: > > /* > * A missing feature before all negotiations finished will still be missing > at the end. > */ > bool virtio_test_backend_unsupp

Re: [Qemu-devel] [PATCH 1/2] virtio: Add backend feature testing functionnality

2016-09-09 Thread Marcel Apfelbaum
On 09/09/2016 01:55 PM, Cornelia Huck wrote: On Fri, 9 Sep 2016 13:48:00 +0300 Marcel Apfelbaum wrote: On 09/09/2016 01:33 PM, Cornelia Huck wrote: On Fri, 9 Sep 2016 12:14:31 +0200 Maxime Coquelin wrote: This patch adds virtio_test_backend_feature() function to enable checking a backend

Re: [Qemu-devel] [PATCH 1/2] virtio: Add backend feature testing functionnality

2016-09-09 Thread Cornelia Huck
On Fri, 9 Sep 2016 13:48:00 +0300 Marcel Apfelbaum wrote: > On 09/09/2016 01:33 PM, Cornelia Huck wrote: > > On Fri, 9 Sep 2016 12:14:31 +0200 > > Maxime Coquelin wrote: > > > >> This patch adds virtio_test_backend_feature() function to > >> enable checking a backend feature before the negociat

Re: [Qemu-devel] [PATCH 1/2] virtio: Add backend feature testing functionnality

2016-09-09 Thread Marcel Apfelbaum
On 09/09/2016 01:33 PM, Cornelia Huck wrote: On Fri, 9 Sep 2016 12:14:31 +0200 Maxime Coquelin wrote: This patch adds virtio_test_backend_feature() function to enable checking a backend feature before the negociation takes place. It may be used, for example, to check whether the backend supp

Re: [Qemu-devel] [PATCH 1/2] virtio: Add backend feature testing functionnality

2016-09-09 Thread Cornelia Huck
On Fri, 9 Sep 2016 12:14:31 +0200 Maxime Coquelin wrote: > This patch adds virtio_test_backend_feature() function to > enable checking a backend feature before the negociation > takes place. > > It may be used, for example, to check whether the backend > supports VIRTIO_F_VERSION_1 before enabl

[Qemu-devel] [PATCH 1/2] virtio: Add backend feature testing functionnality

2016-09-09 Thread Maxime Coquelin
This patch adds virtio_test_backend_feature() function to enable checking a backend feature before the negociation takes place. It may be used, for example, to check whether the backend supports VIRTIO_F_VERSION_1 before enabling modern capabilities. Cc: Marcel Apfelbaum Cc: Michael S. Tsirkin