Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

On Fri, 09 Sep 2016 11:08:56 +0200 Markus Armbruster wrote: > Greg Kurz writes: > > > On Fri, 09 Sep 2016 08:38:13 +0200 > > Markus Armbruster wrote: > > > >> Greg Kurz writes: > >> > >> > On Thu, 8 Sep 2016 18:19:27

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

On Fri, 9 Sep 2016 11:26:17 +0200 Greg Kurz wrote: > > > > Stefan had already sent > > <1460467534-29147-4-git-send-email-stefa...@redhat.com> ages ago, but > > it has not yet made it anywhere... > > > > I don't know what to do with this message-id :\ I finally found :)

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

On Fri, 9 Sep 2016 10:53:05 +0200 Cornelia Huck wrote: > On Fri, 9 Sep 2016 10:46:25 +0200 > Greg Kurz wrote: > > > On Fri, 9 Sep 2016 10:30:53 +0200 > > Cornelia Huck wrote: > > > > > On Thu, 8 Sep 2016 19:55:16 +0300 > >

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

Greg Kurz writes: > On Fri, 09 Sep 2016 08:38:13 +0200 > Markus Armbruster wrote: > >> Greg Kurz writes: >> >> > On Thu, 8 Sep 2016 18:19:27 +0300 >> > "Michael S. Tsirkin" wrote: >> > >> >> On Thu, Sep 08, 2016 at

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

On Fri, 9 Sep 2016 10:46:25 +0200 Greg Kurz wrote: > On Fri, 9 Sep 2016 10:30:53 +0200 > Cornelia Huck wrote: > > > On Thu, 8 Sep 2016 19:55:16 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Sep 08, 2016 at 06:26:52PM +0200,

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

On Fri, 9 Sep 2016 10:30:53 +0200 Cornelia Huck wrote: > On Thu, 8 Sep 2016 19:55:16 +0300 > "Michael S. Tsirkin" wrote: > > > On Thu, Sep 08, 2016 at 06:26:52PM +0200, Greg Kurz wrote: > > > On Thu, 8 Sep 2016 18:19:27 +0300 > > > "Michael S.

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

On Thu, 8 Sep 2016 19:55:16 +0300 "Michael S. Tsirkin" wrote: > On Thu, Sep 08, 2016 at 06:26:52PM +0200, Greg Kurz wrote: > > On Thu, 8 Sep 2016 18:19:27 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Sep 08, 2016 at 05:04:47PM +0200, Cornelia Huck

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

On Fri, 09 Sep 2016 08:38:13 +0200 Markus Armbruster wrote: > Greg Kurz writes: > > > On Thu, 8 Sep 2016 18:19:27 +0300 > > "Michael S. Tsirkin" wrote: > > > >> On Thu, Sep 08, 2016 at 05:04:47PM +0200, Cornelia Huck wrote: > >> > On

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

Greg Kurz writes: > On Thu, 8 Sep 2016 18:19:27 +0300 > "Michael S. Tsirkin" wrote: > >> On Thu, Sep 08, 2016 at 05:04:47PM +0200, Cornelia Huck wrote: >> > On Thu, 8 Sep 2016 18:00:28 +0300 >> > "Michael S. Tsirkin" wrote: >> > >> > > On

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

On Thu, Sep 08, 2016 at 06:26:52PM +0200, Greg Kurz wrote: > On Thu, 8 Sep 2016 18:19:27 +0300 > "Michael S. Tsirkin" wrote: > > > On Thu, Sep 08, 2016 at 05:04:47PM +0200, Cornelia Huck wrote: > > > On Thu, 8 Sep 2016 18:00:28 +0300 > > > "Michael S. Tsirkin"

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

On Thu, Sep 08, 2016 at 05:04:47PM +0200, Cornelia Huck wrote: > On Thu, 8 Sep 2016 18:00:28 +0300 > "Michael S. Tsirkin" wrote: > > > On Thu, Sep 08, 2016 at 11:12:16AM +0200, Greg Kurz wrote: > > > On Thu, 8 Sep 2016 10:59:26 +0200 > > > Cornelia Huck

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

On Thu, 8 Sep 2016 18:19:27 +0300 "Michael S. Tsirkin" wrote: > On Thu, Sep 08, 2016 at 05:04:47PM +0200, Cornelia Huck wrote: > > On Thu, 8 Sep 2016 18:00:28 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Sep 08, 2016 at 11:12:16AM +0200, Greg Kurz

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

On Thu, Sep 08, 2016 at 11:12:16AM +0200, Greg Kurz wrote: > On Thu, 8 Sep 2016 10:59:26 +0200 > Cornelia Huck wrote: > > > On Wed, 07 Sep 2016 19:19:24 +0200 > > Greg Kurz wrote: > > > > > Calling assert() really makes sense when hitting a genuine

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

On Thu, 8 Sep 2016 18:00:28 +0300 "Michael S. Tsirkin" wrote: > On Thu, Sep 08, 2016 at 11:12:16AM +0200, Greg Kurz wrote: > > On Thu, 8 Sep 2016 10:59:26 +0200 > > Cornelia Huck wrote: > > > > > On Wed, 07 Sep 2016 19:19:24 +0200 > > > Greg Kurz

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

On Thu, 08 Sep 2016 09:14:05 +0200 Markus Armbruster wrote: > Greg Kurz writes: > > > Calling assert() really makes sense when hitting a genuine bug, which calls > > for a fix in QEMU. However, when something goes wrong because the guest > > sends a malformed

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

On Thu, 8 Sep 2016 10:59:26 +0200 Cornelia Huck wrote: > On Wed, 07 Sep 2016 19:19:24 +0200 > Greg Kurz wrote: > > > Calling assert() really makes sense when hitting a genuine bug, which calls > > for a fix in QEMU. However, when something goes wrong

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

On Wed, 07 Sep 2016 19:19:24 +0200 Greg Kurz wrote: > Calling assert() really makes sense when hitting a genuine bug, which calls > for a fix in QEMU. However, when something goes wrong because the guest > sends a malformed message, it is better to write down a more meaningul >

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

Greg Kurz writes: > Calling assert() really makes sense when hitting a genuine bug, which calls > for a fix in QEMU. However, when something goes wrong because the guest > sends a malformed message, it is better to write down a more meaningul > error message and exit. > >

[Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

Calling assert() really makes sense when hitting a genuine bug, which calls for a fix in QEMU. However, when something goes wrong because the guest sends a malformed message, it is better to write down a more meaningul error message and exit. Signed-off-by: Greg Kurz ---