Re: [Qemu-devel] [PATCH 1/2] virtio-blk: Remove useless condition around g_free()

2017-04-23 Thread Michael Tokarev
07.02.2017 16:27, Fam Zheng wrote: > Laszlo spotted and studied this wasteful "if". He pointed out: > > The original virtio_blk_free_request needed an "if" as it accesses one > field, since 671ec3f05655 ("virtio-blk: Convert VirtIOBlockReq.elem to > pointer", 2014-06-11); later on in f897bf751fbd

Re: [Qemu-devel] [PATCH 1/2] virtio-blk: Remove useless condition around g_free()

2017-03-07 Thread Fam Zheng
On Tue, 02/07 21:27, Fam Zheng wrote: > Laszlo spotted and studied this wasteful "if". He pointed out: > > The original virtio_blk_free_request needed an "if" as it accesses one > field, since 671ec3f05655 ("virtio-blk: Convert VirtIOBlockReq.elem to > pointer", 2014-06-11); later on in f897bf751f

Re: [Qemu-devel] [PATCH 1/2] virtio-blk: Remove useless condition around g_free()

2017-02-07 Thread Laszlo Ersek
On 02/07/17 14:27, Fam Zheng wrote: > Laszlo spotted and studied this wasteful "if". He pointed out: > > The original virtio_blk_free_request needed an "if" as it accesses one > field, since 671ec3f05655 ("virtio-blk: Convert VirtIOBlockReq.elem to > pointer", 2014-06-11); later on in f897bf751fbd

[Qemu-devel] [PATCH 1/2] virtio-blk: Remove useless condition around g_free()

2017-02-07 Thread Fam Zheng
Laszlo spotted and studied this wasteful "if". He pointed out: The original virtio_blk_free_request needed an "if" as it accesses one field, since 671ec3f05655 ("virtio-blk: Convert VirtIOBlockReq.elem to pointer", 2014-06-11); later on in f897bf751fbd ("virtio-blk: embed VirtQueueElement in VirtI