Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices

2017-02-22 Thread Eric Blake
On 02/22/2017 10:59 AM, Greg Kurz wrote: I see these parameter names as stable. There is little risk that they would change. >> >> We just need to be sure that when we do add QMP, that it doesn't use >> names that differ from the command line (blockdev is an example where we >>

Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices

2017-02-22 Thread Greg Kurz
On Wed, 22 Feb 2017 10:01:09 -0600 Eric Blake wrote: > On 02/22/2017 07:41 AM, Greg Kurz wrote: > > Eric, > > > > I fully understand your concern about the missing QMP bits, but given the > > other > > comments people made on this series, I'd like to move forward and merge

Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices

2017-02-22 Thread Eric Blake
On 02/22/2017 07:41 AM, Greg Kurz wrote: > Eric, > > I fully understand your concern about the missing QMP bits, but given the > other > comments people made on this series, I'd like to move forward and merge it for > 2.9, without the 'x-' prefixed options. Is it okay with you ? Yes, I think

Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices

2017-02-22 Thread Greg Kurz
Eric, I fully understand your concern about the missing QMP bits, but given the other comments people made on this series, I'd like to move forward and merge it for 2.9, without the 'x-' prefixed options. Is it okay with you ? Cheers. -- Greg On Tue, 14 Feb 2017 13:21:22 + Stefan Hajnoczi

Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices

2017-02-14 Thread Stefan Hajnoczi
On Tue, Feb 07, 2017 at 05:29:33PM +0100, Greg Kurz wrote: > Cc'ing Stefan who reviewed patch 2/2. > > On Tue, 7 Feb 2017 09:56:08 -0600 > Eric Blake wrote: > > > On 02/07/2017 04:32 AM, Greg Kurz wrote: > > >> > > >> I'm not aware of anything related to fsdev in QMP... and

Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices

2017-02-07 Thread Greg Kurz
Cc'ing Stefan who reviewed patch 2/2. On Tue, 7 Feb 2017 09:56:08 -0600 Eric Blake wrote: > On 02/07/2017 04:32 AM, Greg Kurz wrote: > >> > >> I'm not aware of anything related to fsdev in QMP... and libvirt seems to > >> only parse the output of -help to guess fsdev

Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices

2017-02-07 Thread Eric Blake
On 02/07/2017 04:32 AM, Greg Kurz wrote: >> >> I'm not aware of anything related to fsdev in QMP... and libvirt seems to >> only parse the output of -help to guess fsdev capabilities. > > Oops, reading some more libvirt code I now see that libvirt doesn't parse > -help anymore with QEMU >=

Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices

2017-02-07 Thread Pradeep Jagadeesh
On 2/6/2017 8:36 PM, Eric Blake wrote: On 02/03/2017 05:57 AM, Pradeep Jagadeesh wrote: This patchset adds the throttle support for the 9p-local driver. For now this functionality can be enabled only through qemu cli options. QMP interface and support to other drivers need further extensions.

Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices

2017-02-07 Thread Greg Kurz
On Tue, 7 Feb 2017 00:15:33 +0100 Greg Kurz wrote: > On Mon, 6 Feb 2017 13:36:43 -0600 > Eric Blake wrote: > > > On 02/03/2017 05:57 AM, Pradeep Jagadeesh wrote: > > > This patchset adds the throttle support for the 9p-local driver. > > > For now this

Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices

2017-02-06 Thread Fam Zheng
On Mon, 02/06 13:36, Eric Blake wrote: > On 02/03/2017 05:57 AM, Pradeep Jagadeesh wrote: > > This patchset adds the throttle support for the 9p-local driver. > > For now this functionality can be enabled only through qemu cli options. > > QMP interface and support to other drivers need further

Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices

2017-02-06 Thread Greg Kurz
On Mon, 6 Feb 2017 13:36:43 -0600 Eric Blake wrote: > On 02/03/2017 05:57 AM, Pradeep Jagadeesh wrote: > > This patchset adds the throttle support for the 9p-local driver. > > For now this functionality can be enabled only through qemu cli options. > > QMP interface and

Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices

2017-02-06 Thread Eric Blake
On 02/03/2017 05:57 AM, Pradeep Jagadeesh wrote: > This patchset adds the throttle support for the 9p-local driver. > For now this functionality can be enabled only through qemu cli options. > QMP interface and support to other drivers need further extensions. This part is a bit scary - if 2.9 is

Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices

2017-02-03 Thread Alberto Garcia
On Fri 03 Feb 2017 12:57:22 PM CET, Pradeep Jagadeesh wrote: > This patchset adds the throttle support for the 9p-local driver. For > now this functionality can be enabled only through qemu cli options. > QMP interface and support to other drivers need further extensions. > To make it simple for

[Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices

2017-02-03 Thread Pradeep Jagadeesh
This patchset adds the throttle support for the 9p-local driver. For now this functionality can be enabled only through qemu cli options. QMP interface and support to other drivers need further extensions. To make it simple for other 9p drivers, the throttle code has been put in separate files.