Re: [Qemu-devel] [PATCH 1/2 v2] Add blkmirror block driver

2012-02-27 Thread Federico Simoncelli
- Original Message - From: Luiz Capitulino lcapitul...@redhat.com To: Federico Simoncelli fsimo...@redhat.com Cc: qemu-devel@nongnu.org, mtosa...@redhat.com, pbonz...@redhat.com, kw...@redhat.com, arm...@redhat.com Sent: Friday, February 24, 2012 7:17:22 PM Subject: Re: [PATCH 1/2

[Qemu-devel] [PATCH 1/2 v2] Add blkmirror block driver

2012-02-24 Thread Federico Simoncelli
From: Marcelo Tosatti mtosa...@redhat.com Mirrored writes are used by live block copy. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Signed-off-by: Federico Simoncelli fsimo...@redhat.com --- Makefile.objs |2 +- block/blkmirror.c | 247

Re: [Qemu-devel] [PATCH 1/2 v2] Add blkmirror block driver

2012-02-24 Thread Eric Blake
On 02/24/2012 09:49 AM, Federico Simoncelli wrote: From: Marcelo Tosatti mtosa...@redhat.com Mirrored writes are used by live block copy. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Signed-off-by: Federico Simoncelli fsimo...@redhat.com --- +++ b/block/blkmirror.c @@ -0,0 +1,247

Re: [Qemu-devel] [PATCH 1/2 v2] Add blkmirror block driver

2012-02-24 Thread Federico Simoncelli
: Re: [Qemu-devel] [PATCH 1/2 v2] Add blkmirror block driver +++ b/docs/blkmirror.txt @@ -0,0 +1,16 @@ +Block mirror driver +--- + +This driver will mirror writes to two distinct images. +It's used internally by live block copy. + +Format +-- + +blkmirror

Re: [Qemu-devel] [PATCH 1/2 v2] Add blkmirror block driver

2012-02-24 Thread Luiz Capitulino
On Fri, 24 Feb 2012 16:49:03 + Federico Simoncelli fsimo...@redhat.com wrote: From: Marcelo Tosatti mtosa...@redhat.com Mirrored writes are used by live block copy. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Signed-off-by: Federico Simoncelli fsimo...@redhat.com ---

Re: [Qemu-devel] [PATCH 1/2 v2] Add blkmirror block driver

2012-02-24 Thread Paolo Bonzini
On 02/24/2012 06:02 PM, Eric Blake wrote: Is the escaping of : and \ only necessary for image1.img, or for both image1 and image2? I need to know if the parser is consistent for both arguments, but this wording makes it sound like it is only for the first argument. libvirt is completely