Re: [Qemu-devel] [PATCH 1/3] HMP: add QDict to info callback handler

2012-12-24 Thread Wenchao Xia
OK, will add that in commit message. > > For now, the new argument is NULL, not an empty dictionary. Could be > mentioned in the commit message. Not worth a respin. > > [...] > -- Best Regards Wenchao Xia

Re: [Qemu-devel] [PATCH 1/3] HMP: add QDict to info callback handler

2012-12-21 Thread Markus Armbruster
Wenchao Xia writes: > This patch change all info call back function to take > additional QDict * parameter, which allow those command > take parameter. [...] > diff --git a/monitor.c b/monitor.c > index c0e32d6..797680f 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -123,7 +123,7 @@ typedef st

[Qemu-devel] [PATCH 1/3] HMP: add QDict to info callback handler

2012-12-19 Thread Wenchao Xia
This patch change all info call back function to take additional QDict * parameter, which allow those command take parameter. Signed-off-by: Wenchao Xia --- hmp.c | 36 ++-- hmp.h | 36 ++-- hw/i825