Re: [Qemu-devel] [PATCH 1/3] Improve grlib-apbuart

2013-02-19 Thread Fabien Chouteau
On 02/19/2013 02:26 PM, Andreas Färber wrote: > Am 19.02.2013 12:45, schrieb Fabien Chouteau: >> From: Ronald Hecht >> >> From: Ronald Hecht >> >> Signed-off-by: Fabien Chouteau > > Duplicate From header and no proper commit message. > The patch is doing too many things at once: Renaming gptime

Re: [Qemu-devel] [PATCH 1/3] Improve grlib-apbuart

2013-02-19 Thread Andreas Färber
Am 19.02.2013 12:45, schrieb Fabien Chouteau: > From: Ronald Hecht > > From: Ronald Hecht > > Signed-off-by: Fabien Chouteau Duplicate From header and no proper commit message. The patch is doing too many things at once: Renaming gptimer ->apbuart should go into its own patch for instance and

[Qemu-devel] [PATCH 1/3] Improve grlib-apbuart

2013-02-19 Thread Fabien Chouteau
From: Ronald Hecht From: Ronald Hecht Signed-off-by: Fabien Chouteau --- hw/grlib_apbuart.c | 52 +--- 1 file changed, 37 insertions(+), 15 deletions(-) diff --git a/hw/grlib_apbuart.c b/hw/grlib_apbuart.c index 760bed0..ba1685a 100644 --- a/