Re: [Qemu-devel] [PATCH 1/3] Mediated device Core driver

2016-07-04 Thread Xiao Guangrong
On 07/01/2016 02:51 AM, Kirti Wankhede wrote: On 6/29/2016 7:21 PM, Xiao Guangrong wrote: On 06/21/2016 12:31 AM, Kirti Wankhede wrote: Design for Mediated Device Driver: ... +static int mdev_add_attribute_group(struct device *dev, +const struct attribute_group **gro

Re: [Qemu-devel] [PATCH 1/3] Mediated device Core driver

2016-07-03 Thread Jike Song
On 06/21/2016 12:31 AM, Kirti Wankhede wrote: > +/* > + * mdev_register_device : Register a device > + * @dev: device structure representing parent device. > + * @ops: Parent device operation structure to be registered. > + * > + * Add device to list of registered parent devices. > + * Returns a ne

Re: [Qemu-devel] [PATCH 1/3] Mediated device Core driver

2016-06-30 Thread Kirti Wankhede
On 6/30/2016 12:42 PM, Jike Song wrote: > On 06/29/2016 09:51 PM, Xiao Guangrong wrote: >> On 06/21/2016 12:31 AM, Kirti Wankhede wrote: >>> + mutex_unlock(&parent_devices.list_lock); >>> + return parent; >>> +} >>> + >>> +static int mdev_device_create_ops(struct mdev_device *mdev, char >>>

Re: [Qemu-devel] [PATCH 1/3] Mediated device Core driver

2016-06-30 Thread Kirti Wankhede
On 6/29/2016 7:21 PM, Xiao Guangrong wrote: > > > On 06/21/2016 12:31 AM, Kirti Wankhede wrote: >> Design for Mediated Device Driver: ... >> +static int mdev_add_attribute_group(struct device *dev, >> +const struct attribute_group **groups) >> +{ >> +return sysfs_create_

Re: [Qemu-devel] [PATCH 1/3] Mediated device Core driver

2016-06-30 Thread Kirti Wankhede
On 6/25/2016 1:10 AM, Alex Williamson wrote: > On Fri, 24 Jun 2016 23:24:58 +0530 > Kirti Wankhede wrote: > >> Alex, >> >> Thanks for taking closer look. I'll incorporate all the nits you suggested. >> >> On 6/22/2016 3:00 AM, Alex Williamson wrote: >>> On Mon, 20 Jun 2016 22:01:46 +0530 >>> Ki

Re: [Qemu-devel] [PATCH 1/3] Mediated device Core driver

2016-06-30 Thread Jike Song
On 06/29/2016 09:51 PM, Xiao Guangrong wrote: > On 06/21/2016 12:31 AM, Kirti Wankhede wrote: >> +mutex_unlock(&parent_devices.list_lock); >> +return parent; >> +} >> + >> +static int mdev_device_create_ops(struct mdev_device *mdev, char >> *mdev_params) >> +{ >> +struct parent_device

Re: [Qemu-devel] [PATCH 1/3] Mediated device Core driver

2016-06-29 Thread Xiao Guangrong
On 06/21/2016 12:31 AM, Kirti Wankhede wrote: Design for Mediated Device Driver: Main purpose of this driver is to provide a common interface for mediated device management that can be used by differnt drivers of different devices. This module provides a generic interface to create the device,

Re: [Qemu-devel] [PATCH 1/3] Mediated device Core driver

2016-06-24 Thread Alex Williamson
On Fri, 24 Jun 2016 23:24:58 +0530 Kirti Wankhede wrote: > Alex, > > Thanks for taking closer look. I'll incorporate all the nits you suggested. > > On 6/22/2016 3:00 AM, Alex Williamson wrote: > > On Mon, 20 Jun 2016 22:01:46 +0530 > > Kirti Wankhede wrote: > > > ... > >> + > >> +config MDE

Re: [Qemu-devel] [PATCH 1/3] Mediated device Core driver

2016-06-24 Thread Kirti Wankhede
Alex, Thanks for taking closer look. I'll incorporate all the nits you suggested. On 6/22/2016 3:00 AM, Alex Williamson wrote: > On Mon, 20 Jun 2016 22:01:46 +0530 > Kirti Wankhede wrote: > ... >> + >> +config MDEV >> +tristate "Mediated device driver framework" >> +depends on VFIO >> +

Re: [Qemu-devel] [PATCH 1/3] Mediated device Core driver

2016-06-21 Thread Alex Williamson
On Mon, 20 Jun 2016 22:01:46 +0530 Kirti Wankhede wrote: > Design for Mediated Device Driver: > Main purpose of this driver is to provide a common interface for mediated > device management that can be used by differnt drivers of different > devices. > > This module provides a generic interface

Re: [Qemu-devel] [PATCH 1/3] Mediated device Core driver

2016-06-21 Thread Jike Song
On 06/21/2016 12:31 AM, Kirti Wankhede wrote: > + > +static int mdev_add_attribute_group(struct device *dev, > + const struct attribute_group **groups) > +{ > + return sysfs_create_groups(&dev->kobj, groups); > +} > + > +static void mdev_remove_attribute_group(st

[Qemu-devel] [PATCH 1/3] Mediated device Core driver

2016-06-20 Thread Kirti Wankhede
Design for Mediated Device Driver: Main purpose of this driver is to provide a common interface for mediated device management that can be used by differnt drivers of different devices. This module provides a generic interface to create the device, add it to mediated bus, add device to IOMMU group