Re: [Qemu-devel] [PATCH 1/3] linux-user: Restrict usage of sa_restorer

2017-03-11 Thread Richard Henderson
On 03/12/2017 07:02 AM, Richard Henderson wrote: TARGET_ALPHA has KA_RESTORER, not sa_restorer. The restorer value is passed to sigaction in a 5th register argument. Less than handy that qemu doesn't distinguish the two structs... I beg your pardon, we do -- they're just named confusingly. t

Re: [Qemu-devel] [PATCH 1/3] linux-user: Restrict usage of sa_restorer

2017-03-11 Thread Richard Henderson
On 03/12/2017 04:28 AM, Laurent Vivier wrote: Le 11/03/2017 à 04:42, Richard Henderson a écrit : Reading and writing to an sa_restorer member that isn't supposed to exist corrupts user memory. Introduce TARGET_ARCH_HAS_SA_RESTORER, similar to the kernel's __ARCH_HAS_SA_RESTORER. Reported-by: H

Re: [Qemu-devel] [PATCH 1/3] linux-user: Restrict usage of sa_restorer

2017-03-11 Thread Laurent Vivier
Le 11/03/2017 à 04:42, Richard Henderson a écrit : > Reading and writing to an sa_restorer member that isn't supposed to > exist corrupts user memory. Introduce TARGET_ARCH_HAS_SA_RESTORER, > similar to the kernel's __ARCH_HAS_SA_RESTORER. > > Reported-by: Helge Deller > Signed-off-by: Richard H

[Qemu-devel] [PATCH 1/3] linux-user: Restrict usage of sa_restorer

2017-03-10 Thread Richard Henderson
Reading and writing to an sa_restorer member that isn't supposed to exist corrupts user memory. Introduce TARGET_ARCH_HAS_SA_RESTORER, similar to the kernel's __ARCH_HAS_SA_RESTORER. Reported-by: Helge Deller Signed-off-by: Richard Henderson --- linux-user/signal.c | 4 ++-- linux-user/