Re: [Qemu-devel] [PATCH 1/3] mirror: Go through ready - complete process for 0 len image

2014-06-05 Thread Stefan Hajnoczi
On Thu, Jun 05, 2014 at 11:42:34AM +0800, Fam Zheng wrote: diff --git a/block/mirror.c b/block/mirror.c index 94c8661..2bef5f3 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -324,9 +324,18 @@ static void coroutine_fn mirror_run(void *opaque) } s-common.len =

Re: [Qemu-devel] [PATCH 1/3] mirror: Go through ready - complete process for 0 len image

2014-06-05 Thread Paolo Bonzini
Il 05/06/2014 13:17, Stefan Hajnoczi ha scritto: On Thu, Jun 05, 2014 at 11:42:34AM +0800, Fam Zheng wrote: diff --git a/block/mirror.c b/block/mirror.c index 94c8661..2bef5f3 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -324,9 +324,18 @@ static void coroutine_fn mirror_run(void *opaque)

[Qemu-devel] [PATCH 1/3] mirror: Go through ready - complete process for 0 len image

2014-06-04 Thread Fam Zheng
When mirroring or active committing a zero length image, BLOCK_JOB_READY is not reported now, instead the job completes because we short circuit the mirror job loop. This is inconsistent with non-zero length images, and only confuses management software. Let's do the same thing when seeing a